linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 6/9] brcmfmac: Add RSDB support.
Date: Thu, 12 Nov 2015 21:49:48 +0200	[thread overview]
Message-ID: <87io57576r.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1446147199-21671-7-git-send-email-arend@broadcom.com> (Arend van Spriel's message of "Thu, 29 Oct 2015 20:33:16 +0100")

Arend van Spriel <arend@broadcom.com> writes:

> From: Hante Meuleman <meuleman@broadcom.com>
>
> RSDB works almost autonomously in firmware except for AP config.
> When device supports RSDB then the interface should not be
> brought down when configuring it, otherwise the link (if
> configured) on the other interface will be lost.
>
> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>

I have never heard of acronym RSDB before and after some googling I
think it might mean Real Simultaneous Dual Band. But please try to avoid
using acronyms and clearly spell it out in the commit log what the
feature is about.

If you send me suggestions what to add I can edit the commit log before
I apply this patch.

-- 
Kalle Valo

  reply	other threads:[~2015-11-12 19:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 19:33 [PATCH 0/9] brcmfmac: new device support and cleanup Arend van Spriel
2015-10-29 19:33 ` [PATCH 1/9] brcmfmac: Add support for the BCM4359 11ac RSDB PCIE device Arend van Spriel
2015-11-26 11:57   ` [1/9] " Kalle Valo
2015-11-27  8:59     ` Arend van Spriel
2015-11-30 11:17       ` Kalle Valo
2015-11-30 11:59         ` Arend van Spriel
2015-10-29 19:33 ` [PATCH 2/9] brcmfmac: Simplify and fix usage of brcmf_ifname Arend van Spriel
2015-10-29 19:33 ` [PATCH 3/9] brcmfmac: Remove unnecessary check from start_xmit Arend van Spriel
2015-10-29 19:33 ` [PATCH 4/9] brcmfmac: Remove unncessary variable irq_requested Arend van Spriel
2015-10-29 19:33 ` [PATCH 5/9] brcmfmac: Disable runtime pm for USB Arend van Spriel
2015-10-29 19:33 ` [PATCH 6/9] brcmfmac: Add RSDB support Arend van Spriel
2015-11-12 19:49   ` Kalle Valo [this message]
2015-11-13  9:11     ` Arend van Spriel
2015-11-13  9:29       ` Kalle Valo
2015-10-29 19:33 ` [PATCH 7/9] brcmfmac: Use consistent naming for bsscfgidx Arend van Spriel
2015-10-29 19:33 ` [PATCH 8/9] brcmfmac: Use new methods for pcie Power Management Arend van Spriel
2015-10-29 19:33 ` [PATCH 9/9] brcmfmac: Add wowl wake indication report Arend van Spriel
2015-10-29 19:49 ` [PATCH 0/9] brcmfmac: new device support and cleanup Kalle Valo
2015-10-29 20:00   ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io57576r.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=arend@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=meuleman@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).