From: Kalle Valo <kvalo@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>,
linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: Re: [PATCH 4/5] wil6210: stop_ap to leave interface closed
Date: Wed, 08 Apr 2015 11:06:21 +0300 [thread overview]
Message-ID: <87iod7hwn6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <4C0E19B4-8F05-47B6-B32F-B60F0BC03D3A@sipsolutions.net> (Johannes Berg's message of "Tue, 07 Apr 2015 21:52:16 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
>>>> "closed" is rather misleading, since you most certainly should *not*
>>do
>>>> dev_close() [and don't, but how should I know reading the commit
>>log?]
>>>>
>>>> johannes
>>>>
>>>
>>> Yes, I see.
>>> I meant that actually stop_ap leaves device in state similar to
>>ndo_stop,
>>> where it is non operational.
>>>
>>> Would you suggest better wording? "Inactive", "down", "non
>>operational"
>>> or something else?
>>
>>Isn't "down" good enough here? So can I change it to:
>
> Well that kinda proves my point - down is wrong.
>
> Carrier turned off is probably the right thing to do here.
Ok, I change the commit log to:
cfg80211_ops.stop_ap supposed to have interface carried turned off as
post condition. Fulfill this requirement.
--
Kalle Valo
next prev parent reply other threads:[~2015-04-08 8:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 8:28 [PATCH 0/5] wil6210 patches Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 1/5] wil6210: fw debug mode Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 2/5] wil6210: debug [add|del]_key operations Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 3/5] wil6210: trace disconnect source Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 4/5] wil6210: stop_ap to leave interface closed Vladimir Kondratiev
2015-03-30 8:45 ` Johannes Berg
2015-03-30 13:56 ` Vladimir Kondratiev
2015-04-07 16:30 ` Kalle Valo
2015-04-07 19:52 ` Johannes Berg
2015-04-08 8:06 ` Kalle Valo [this message]
2015-03-30 8:28 ` [PATCH 5/5] wil6210: update FW file name Vladimir Kondratiev
2015-03-30 9:38 ` Kalle Valo
2015-03-30 14:00 ` Vladimir Kondratiev
2015-03-30 14:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iod7hwn6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=QCA_vkondrat@QCA.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).