From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Fix getting stats from firmware.
Date: Fri, 21 Mar 2014 18:09:48 +0200 [thread overview]
Message-ID: <87ior7a5yr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <532C6138.7010201@candelatech.com> (Ben Greear's message of "Fri, 21 Mar 2014 08:56:40 -0700")
Ben Greear <greearb@candelatech.com> writes:
> On 03/20/2014 11:33 PM, Michal Kazior wrote:
>> On 21 March 2014 01:05, <greearb@candelatech.com> wrote:
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> Make the request command object the right size so that
>>> firmware will not just throw it away.
>>> Tested customized and upstream firmware.
>>
>> Did you test 636 as well? 636 doesn't seem to support more than just `stats_id`.
>
> The firmware source I have checks in such a way that sending too
> large of a cmd should be fine, only too small of a command packet
> causes it to be ignored.
>
> I do not have the 636 firmware to test against.
The firmare image is here:
https://github.com/kvalo/ath10k-firmware/tree/master/main
--
Kalle Valo
prev parent reply other threads:[~2014-03-21 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 0:05 [PATCH] ath10k: Fix getting stats from firmware greearb
2014-03-21 6:33 ` Michal Kazior
2014-03-21 6:41 ` Yeoh Chun-Yeow
2014-03-21 16:03 ` Ben Greear
2014-03-21 16:12 ` Kalle Valo
2014-03-21 16:42 ` Yeoh Chun-Yeow
2014-03-21 16:48 ` Yeoh Chun-Yeow
2014-03-21 18:51 ` Ben Greear
2014-03-21 17:29 ` Ben Greear
2014-03-21 15:56 ` Ben Greear
2014-03-21 16:09 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ior7a5yr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).