From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jones Desougi <jones.desougi@27m.se>
Cc: Joe Perches <joe@perches.com>, <ath6kl@lists.infradead.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/6] ath6kl: use braces on both arms of if statement
Date: Wed, 12 Mar 2014 10:52:11 +0200 [thread overview]
Message-ID: <87iorjg5ok.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <53201F25.30200@27m.se> (Jones Desougi's message of "Wed, 12 Mar 2014 09:47:33 +0100")
Jones Desougi <jones.desougi@27m.se> writes:
> That inverts the meaning of the condition though.
>
>
> On 03/09/2014 10:42 PM, Joe Perches wrote:
> ...
>> - if (bss == NULL) {
> ...
>> - } else
>> + if (!bss) {
>
> if (bss) {
Yeah, that was buggy. Thanks for pointing it out.
--
Kalle Valo
next prev parent reply other threads:[~2014-03-12 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 6:57 [PATCH 0/6] ath6kl: fixing new checkpatch warnings Kalle Valo
2014-03-09 6:57 ` [PATCH 1/6] ath6kl: fix blank lines before and after braces Kalle Valo
2014-03-09 6:57 ` [PATCH 2/6] ath6kl: use braces on both arms of if statement Kalle Valo
2014-03-09 21:42 ` Joe Perches
2014-03-10 17:23 ` Kalle Valo
2014-03-12 8:47 ` Jones Desougi
2014-03-12 8:52 ` Kalle Valo [this message]
2014-03-12 14:11 ` Joe Perches
2014-03-09 6:57 ` [PATCH 3/6] ath6kl: remove spaces before semicolon Kalle Valo
2014-03-09 6:57 ` [PATCH 4/6] ath6kl: remove unnecessary line continuations Kalle Valo
2014-03-09 21:15 ` Joe Perches
2014-03-10 17:26 ` Kalle Valo
2014-03-09 6:57 ` [PATCH 5/6] ath6kl: remove a warning on a macro Kalle Valo
2014-03-09 7:10 ` Kalle Valo
2014-03-09 7:20 ` Joe Perches
2014-03-09 7:44 ` Joe Perches
2014-03-10 17:29 ` Kalle Valo
2014-03-10 20:03 ` Joe Perches
2014-03-09 6:57 ` [PATCH 6/6] ath6kl: update Kconfig descriptions Kalle Valo
2014-03-13 5:48 ` [PATCH 0/6] ath6kl: fixing new checkpatch warnings Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iorjg5ok.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl@lists.infradead.org \
--cc=joe@perches.com \
--cc=jones.desougi@27m.se \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).