From: Kalle Valo <kvalo@adurom.com>
To: Joe Perches <joe@perches.com>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org
Subject: Re: [PATCH v2 13/16] wcn36xx: add wcn36xx.h
Date: Mon, 02 Sep 2013 17:15:55 +0300 [thread overview]
Message-ID: <87ioyjux5w.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1377298929.2816.15.camel@joe-AO722> (Joe Perches's message of "Fri, 23 Aug 2013 16:02:09 -0700")
Joe Perches <joe@perches.com> writes:
>> +#define wcn36xx_dbg(mask, fmt, arg...) do { \
>> + if (debug_mask & mask) \
>> + printk(KERN_DEBUG pr_fmt(fmt), ##arg); \
>> +} while (0)
>
> And maybe this one using pr_debug so dynamic_debug
> can work too.
Please, no dynamic_debug. It's useless on a wifi driver.
--
Kalle Valo
next prev parent reply other threads:[~2013-09-02 14:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 8:58 [PATCH v2 00/16] wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 01/16] wcn36xx: Add main.c Eugene Krasnikov
2013-08-23 9:22 ` Johannes Berg
2013-08-23 9:42 ` Eugene Krasnikov
2013-08-23 9:47 ` Johannes Berg
2013-08-23 10:06 ` Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 02/16] wcn36xx: add debug.c Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 03/16] wcn36xx: add debug.h Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 04/16] wcn36xx: add dxe.c Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 05/16] wcn36xx: add dxe.h Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 06/16] wcn36xx: add hal.h Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 07/16] wcn36xx: add pmc.c Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 08/16] wcn36xx: add pmc.h Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 09/16] wcn36xx: add smd.c Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 10/16] wcn36xx: add smd.h Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 11/16] wcn36xx: add txrx.c Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 12/16] wcn36xx: add txrx.h Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 13/16] wcn36xx: add wcn36xx.h Eugene Krasnikov
2013-08-23 23:02 ` Joe Perches
2013-08-26 7:23 ` Eugene Krasnikov
2013-09-02 14:15 ` Kalle Valo [this message]
2013-09-02 17:49 ` Joe Perches
2013-09-03 5:08 ` Kalle Valo
2013-09-03 5:13 ` Joe Perches
2013-09-03 5:25 ` Kalle Valo
2013-09-03 5:27 ` Joe Perches
2013-09-03 5:39 ` Kalle Valo
2013-09-03 5:41 ` Joe Perches
2013-09-03 5:48 ` Kalle Valo
2013-08-23 8:58 ` [PATCH v2 14/16] wcn36xx: add Makefile Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 15/16] wcn36xx: add Kconfig Eugene Krasnikov
2013-08-23 8:58 ` [PATCH v2 16/16] wcn36xx: Add wcn36xx to ath Makefile and Kconfig Eugene Krasnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioyjux5w.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=joe@perches.com \
--cc=k.eugene.e@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox