From: Kalle Valo <kvalo@adurom.com>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation
Date: Mon, 04 Jul 2011 17:41:49 +0300 [thread overview]
Message-ID: <87ipriyuoi.fsf@purkki.adurom.net> (raw)
In-Reply-To: <CAFtRNNyyx2e3YhKgGwG4h678dEKkQwdVf8pXBtWqYHZzx9r0cQ@mail.gmail.com> (Nick Kossifidis's message of "Mon\, 4 Jul 2011 13\:14\:43 +0300")
Nick Kossifidis <mickflemm@gmail.com> writes:
> O.K. let's comment it out then and add some information that it's
> disabled by default on available HALs...
Leaving dead code lying around is bad. Why not add a comment with some
pointers how to get the old code if someone wants to do that? For
example git commit id is a good reference and I'm sure it will work
even after 10 years.
--
Kalle Valo
next prev parent reply other threads:[~2011-07-04 14:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 5:47 [PATCH 1/8] ath5k: add missing checks for rfgain probe Felix Fietkau
2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau
2011-07-04 5:47 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau
[not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org>
2011-07-04 5:47 ` [PATCH 5/8] ath5k: delay full calibration after reset Felix Fietkau
2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau
2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau
2011-07-04 5:47 ` [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 Felix Fietkau
2011-07-04 9:58 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Nick Kossifidis
2011-07-04 10:07 ` Felix Fietkau
2011-07-04 10:14 ` Nick Kossifidis
2011-07-04 14:41 ` Kalle Valo [this message]
2011-07-04 21:02 ` Nick Kossifidis
2011-07-04 10:25 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Nick Kossifidis
2011-07-04 10:34 ` [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset Nick Kossifidis
2011-07-04 10:40 ` [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate Nick Kossifidis
2011-07-04 10:44 ` Felix Fietkau
2011-07-04 10:49 ` Nick Kossifidis
2011-07-04 10:27 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Nick Kossifidis
2011-07-04 10:29 ` [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Nick Kossifidis
2011-07-04 9:48 ` [PATCH 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis
2011-07-04 9:56 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipriyuoi.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mickflemm@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).