From: Elias Oltmanns <eo@nebensachen.de>
To: "Nick Kossifidis" <mickflemm@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Does not connect reliably on 2.6.27
Date: Wed, 15 Oct 2008 00:01:28 +0200 [thread overview]
Message-ID: <87iqruj0p3.fsf@denkblock.local> (raw)
In-Reply-To: 40f31dec0810141011y265275a8nc083764889d699f1@mail.gmail.com
"Nick Kossifidis" <mickflemm@gmail.com> wrote:
> 2008/10/14 Elias Oltmanns <eo@nebensachen.de>:
>> Hi all,
>
>>
>> after a cold boot into 2.6.27, ath5k doesn't work on my machine. The
>> sequence
>>
>> # ifconfig ath0 up
>> # iwlist ath0 ap
>>
>> results in a message informing me that no list of APs is available for
>> that device.
[...]
>> The minimal patch to fix the issue for me is attached. However, I am
>> wondering whether the preceding writes to register 0xa228 should be
>> dropped or at least adjusted somehow. Perhaps those of you who know the
>> recently released HAL from Atheros can throw some light on the matter.
>>
>> Regards,
>>
>> Elias
>> ---
>> diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
>> index dc51b84..b1cec2a 100644
>> --- a/drivers/net/wireless/ath5k/hw.c
>> +++ b/drivers/net/wireless/ath5k/hw.c
>> @@ -862,7 +862,7 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum ieee80211_if_types op_mode,
>> data = 0;
>>
>> /* Just write 0x9b5 ? */
>> - /* ath5k_hw_reg_write(ah, 0x000009b5, 0xa228); */
>> + ath5k_hw_reg_write(ah, 0x000009b5, 0xa228);
>> ath5k_hw_reg_write(ah, 0x0000000f, AR5K_SEQ_MASK);
>> ath5k_hw_reg_write(ah, 0x00000000, 0xa254);
>> ath5k_hw_reg_write(ah, 0x0000000e, AR5K_PHY_SCAL);
>>
>
> I think i've fixed that (it's a buggy mask some lines above) on an
> earlier patch (the one that introduced AR2425 support) but i'll look
> into it again ;-)
Can you drop me a link or a commit + tree so I can test it?
Regards,
Elias
prev parent reply other threads:[~2008-10-14 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87iqrvgm7b.fsf@denkblock.local>
2008-10-14 17:11 ` [PATCH] ath5k: Does not connect reliably on 2.6.27 Nick Kossifidis
2008-10-14 22:01 ` Elias Oltmanns [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqruj0p3.fsf@denkblock.local \
--to=eo@nebensachen.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).