From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
syzbot+cb7ed9d85261445a0201@syzkaller.appspotmail.com,
Yousef Alhouseen <alhouseenyousef@gmail.com>
Subject: Re: [PATCH] wifi: ath9k: avoid device access after async firmware request
Date: Mon, 29 Jun 2026 11:49:34 +0200 [thread overview]
Message-ID: <87jyrhd6c1.fsf@toke.dk> (raw)
In-Reply-To: <20260628001350.20997-1-alhouseenyousef@gmail.com>
Yousef Alhouseen <alhouseenyousef@gmail.com> writes:
> request_firmware_nowait() may invoke the callback before the requesting
> context resumes. When a firmware lookup fails, the callback starts the
> next fallback request. That nested request can exhaust the fallback list,
> complete fw_done, and let disconnect free hif_dev before the parent request
> returns.
>
> The parent then dereferences hif_dev only to print a successful-request
> message. Remove that post-request access so completion cannot leave an
> older callback using the freed device state.
>
> Fixes: e904cf6fe230 ("ath9k_htc: introduce support for different fw versions")
> Reported-by: syzbot+cb7ed9d85261445a0201@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=cb7ed9d85261445a0201
> Cc: stable@vger.kernel.org
> Signed-off-by: Yousef Alhouseen <alhouseenyousef@gmail.com>
An identical patch was already submitted and is currently pending:
https://patchwork.kernel.org/project/linux-wireless/patch/20260605153210.20471-1-1020691186@qq.com/
-Toke
next prev parent reply other threads:[~2026-06-29 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 0:13 [PATCH] wifi: ath9k: avoid device access after async firmware request Yousef Alhouseen
2026-06-29 9:49 ` Toke Høiland-Jørgensen [this message]
2026-06-29 13:56 ` Yousef Alhouseen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyrhd6c1.fsf@toke.dk \
--to=toke@toke.dk \
--cc=alhouseenyousef@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+cb7ed9d85261445a0201@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox