linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wifi: ath12k: Include MLO memory in firmware coredump collection
@ 2024-12-18  4:01 Raj Kumar Bhagat
  2024-12-19 11:38 ` Kalle Valo
  2025-01-08  0:32 ` Jeff Johnson
  0 siblings, 2 replies; 3+ messages in thread
From: Raj Kumar Bhagat @ 2024-12-18  4:01 UTC (permalink / raw)
  To: ath12k; +Cc: linux-wireless, Raj Kumar Bhagat

The current firmware coredump collection in ath12k does not include
the MLO_GLOBAL_MEM_REGION_TYPE memory. This memory region is essential
for debugging issues related to Multi-Link Operation (MLO).

Hence, add support to include MLO_GLOBAL_MEM_REGION_TYPE memory in
firmware coredump collection.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1

Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/coredump.c | 3 +++
 drivers/net/wireless/ath/ath12k/coredump.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/net/wireless/ath/ath12k/coredump.c b/drivers/net/wireless/ath/ath12k/coredump.c
index 72d675d15e64..ce1beeb54836 100644
--- a/drivers/net/wireless/ath/ath12k/coredump.c
+++ b/drivers/net/wireless/ath/ath12k/coredump.c
@@ -27,6 +27,9 @@ ath12k_fw_crash_dump_type ath12k_coredump_get_dump_type(enum ath12k_qmi_target_m
 	case CALDB_MEM_REGION_TYPE:
 		dump_type = FW_CRASH_DUMP_NONE;
 		break;
+	case MLO_GLOBAL_MEM_REGION_TYPE:
+		dump_type = FW_CRASH_DUMP_MLO_GLOBAL_DATA;
+		break;
 	default:
 		dump_type = FW_CRASH_DUMP_TYPE_MAX;
 		break;
diff --git a/drivers/net/wireless/ath/ath12k/coredump.h b/drivers/net/wireless/ath/ath12k/coredump.h
index 5d6003b1c12d..13f46a605113 100644
--- a/drivers/net/wireless/ath/ath12k/coredump.h
+++ b/drivers/net/wireless/ath/ath12k/coredump.h
@@ -15,6 +15,7 @@ enum ath12k_fw_crash_dump_type {
 	FW_CRASH_DUMP_PAGEABLE_DATA,
 	FW_CRASH_DUMP_M3_DUMP,
 	FW_CRASH_DUMP_NONE,
+	FW_CRASH_DUMP_MLO_GLOBAL_DATA,
 
 	/* keep last */
 	FW_CRASH_DUMP_TYPE_MAX,

base-commit: 9a448415ed0c46edeb9170091a03b620986ca0b2
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] wifi: ath12k: Include MLO memory in firmware coredump collection
  2024-12-18  4:01 [PATCH] wifi: ath12k: Include MLO memory in firmware coredump collection Raj Kumar Bhagat
@ 2024-12-19 11:38 ` Kalle Valo
  2025-01-08  0:32 ` Jeff Johnson
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-12-19 11:38 UTC (permalink / raw)
  To: Raj Kumar Bhagat; +Cc: ath12k, linux-wireless

Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:

> The current firmware coredump collection in ath12k does not include
> the MLO_GLOBAL_MEM_REGION_TYPE memory. This memory region is essential
> for debugging issues related to Multi-Link Operation (MLO).
>
> Hence, add support to include MLO_GLOBAL_MEM_REGION_TYPE memory in
> firmware coredump collection.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>

Acked-by: Kalle Valo <kvalo@kernel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] wifi: ath12k: Include MLO memory in firmware coredump collection
  2024-12-18  4:01 [PATCH] wifi: ath12k: Include MLO memory in firmware coredump collection Raj Kumar Bhagat
  2024-12-19 11:38 ` Kalle Valo
@ 2025-01-08  0:32 ` Jeff Johnson
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2025-01-08  0:32 UTC (permalink / raw)
  To: ath12k, Raj Kumar Bhagat; +Cc: linux-wireless


On Wed, 18 Dec 2024 09:31:49 +0530, Raj Kumar Bhagat wrote:
> The current firmware coredump collection in ath12k does not include
> the MLO_GLOBAL_MEM_REGION_TYPE memory. This memory region is essential
> for debugging issues related to Multi-Link Operation (MLO).
> 
> Hence, add support to include MLO_GLOBAL_MEM_REGION_TYPE memory in
> firmware coredump collection.
> 
> [...]

Applied, thanks!

[1/1] wifi: ath12k: Include MLO memory in firmware coredump collection
      commit: 9035756c18852cf39eeb11b625db094a2c9a4bb9

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-01-08  0:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-18  4:01 [PATCH] wifi: ath12k: Include MLO memory in firmware coredump collection Raj Kumar Bhagat
2024-12-19 11:38 ` Kalle Valo
2025-01-08  0:32 ` Jeff Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).