From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB791BDC8 for ; Wed, 13 Mar 2024 08:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710320285; cv=none; b=nTf5sIr/ZueOiNFJ28hTqgz8FMVgYoOd5bEPczbKjb7AJabAnvxpt4qAwIU5EOEvVOG0MAIKlBnhcECGRiX3EJDecHVqSjtBLXb8NtvGga7j3vZRg1bav+bDnr1aAkWu0pK7ul9P/hIMYFyMZnjXOJ8b+skCW6MMIzrjCt+++hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710320285; c=relaxed/simple; bh=kfDt/vJKTdvg62vRt9dBd/mdmcdvliQsQjMGcnmun3Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=YY5IRI3LkXFNDu8JgN0LLPjkrAczOLQrosjORZj2Rg3/AnsDI6gYIXzZI0aMmutnVR7KHKuWv986iU4vKenv6tTjxKyCHhmY1f+wkOGZpVA5rYgAa7haBMrd3PsVpHwEmP2dWrMT9dho9RO9G/RJQqDqw5W9BFlhgmAjVmxb+0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rq0bhvdO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rq0bhvdO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36F56C433A6; Wed, 13 Mar 2024 08:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710320284; bh=kfDt/vJKTdvg62vRt9dBd/mdmcdvliQsQjMGcnmun3Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rq0bhvdODem8H5mNKhAsqwMwKkx3emuYfZA4KdqLS+znuRnqD+kT2BVJfRzXoWQ0t oMsVa3c4UDx1psrt4baEGgdzJka71wv5lohYUHdW5VQxvqm9ZCvM6l7fDT2liQtB3+ QHGB6V/RS91kVe+ul8MaOHWt8eirls5GeVZZpuLtT+Z0D7EPspmMtJgrzOHbPBhIEH KJxymNi9XVshWqHSCJXt+VTr+/2BYNtTNWK8esBD/qCNgLhiA7bHcJPmsJJofJUMcx duORxfP3sFGCVFRhvviaPW92P9uK9rVrvrzWqvzT4O5P/iEHqsHnEcoi9ByacEctRw VwQAZwY9ST/HA== From: Kalle Valo To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Ping-Ke Shih , Larry Finger , Stefan Lippers-Hollmann , Christian Hewitt Subject: Re: [PATCH 1/3] wifi: rtlwifi: Move code from rtl8192de to rtl8192d-common References: Date: Wed, 13 Mar 2024 10:58:01 +0200 In-Reply-To: (Bitterblue Smith's message of "Wed, 13 Mar 2024 00:18:39 +0200") Message-ID: <87jzm64ig6.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Bitterblue Smith writes: > Create the new module rtl8192d-common and move some code into it from > rtl8192de. Now the rtl8192de driver (PCI) and the new rtl8192du driver > (USB) can share some of the code. > > This is mostly the code that required little effort to make it > shareable. There are a few more functions which they could share, with > some changes. > > The only other changes in this patch should be adjusting whitespace and > renaming some functions. > > Tested only with RTL8192DU. > > Signed-off-by: Bitterblue Smith A cover letter is would be really good to have. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches