From: Kalle Valo <kvalo@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Wang Ming <machel@vivo.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir()
Date: Thu, 20 Jul 2023 09:58:06 +0300 [thread overview]
Message-ID: <87jzuv3w8x.fsf@kernel.org> (raw)
In-Reply-To: <a9dc336793322d3525280e4f30b2acbd0c88bbf8.camel@redhat.com> (Paolo Abeni's message of "Thu, 13 Jul 2023 11:29:30 +0200")
Paolo Abeni <pabeni@redhat.com> writes:
> On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in ath6kl_debug_init_fs() was forgotten.
>>
>> Fix the remaining error check.
>>
>> Signed-off-by: Wang Ming <machel@vivo.com>
>>
>> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs")
>
> The SoB tag should be after the 'Fixes' one and you must avoid empty
> lines in between.
>
> (The same applies to your other patch)
And the same as with the ath9k patch: this should go to ath-next, not
net.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-07-20 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 4:05 [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir() Wang Ming
2023-07-13 9:29 ` Paolo Abeni
[not found] ` <SG2PR06MB374387D043556FE8AEAA6ED9BD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-13 9:43 ` 回复: " Paolo Abeni
2023-07-20 6:58 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzuv3w8x.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=machel@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).