From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7EAEB64DA for ; Thu, 20 Jul 2023 06:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjGTG6N (ORCPT ); Thu, 20 Jul 2023 02:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjGTG6M (ORCPT ); Thu, 20 Jul 2023 02:58:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0A8110; Wed, 19 Jul 2023 23:58:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0780618E3; Thu, 20 Jul 2023 06:58:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEB64C433C8; Thu, 20 Jul 2023 06:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689836290; bh=7mK4Ss6OHN/futLgmH2TgGuEhX+eZoCr1St7KNuM1Ak=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rW7A+yfNq+AWVSYmbDooALBYl0/JFJ3+2+nqaxcFE8jj+p5JxoqT2khnsjgh/NzD9 oy7n8TGTAq5sTOFXmX07dK0eNxRn5eQOFHRuIX4QOzcQGTjlkskvQ+/FBt7QnG5QNu WMScSjUy6Wcfj06CO0yzFT7+i9MFU0XPPwC6D3VyiSsLMPVsR6K/xaajGcg1YZ26RI cPxX6RLsQIRDFucf2itNBo3a2TiiU9Ov34Dg6dfQZq4EFVTa87sonvVs6bTkLeK4ca 6cLwcC/AjZ2bdrlFAdycmJmm86n9iOti6KwaFBgYGY0gMo7KCw86a2U8AYyGr9S7Nt ry2p3who6IsSA== From: Kalle Valo To: Paolo Abeni Cc: Wang Ming , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir() References: <20230713040518.13734-1-machel@vivo.com> Date: Thu, 20 Jul 2023 09:58:06 +0300 In-Reply-To: (Paolo Abeni's message of "Thu, 13 Jul 2023 11:29:30 +0200") Message-ID: <87jzuv3w8x.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Paolo Abeni writes: > On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote: >> The debugfs_create_dir() function returns error pointers, >> it never returns NULL. Most incorrect error checks were fixed, >> but the one in ath6kl_debug_init_fs() was forgotten. >> >> Fix the remaining error check. >> >> Signed-off-by: Wang Ming >> >> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") > > The SoB tag should be after the 'Fixes' one and you must avoid empty > lines in between. > > (The same applies to your other patch) And the same as with the ath9k patch: this should go to ath-next, not net. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches