From: Kalle Valo <kvalo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org,
Claudiu.Beznea@microchip.com, Sripad.Balwadgi@microchip.com,
mwalle@kernel.org
Subject: Re: [PATCH v3] wifi: wilc1000: fix DMA on stack objects
Date: Thu, 11 Aug 2022 07:55:01 +0300 [thread overview]
Message-ID: <87k07fgz16.fsf@kernel.org> (raw)
In-Reply-To: <b1e606e7a36fb900bbc664bbd585ff6a@walle.cc> (Michael Walle's message of "Wed, 10 Aug 2022 14:07:52 +0200")
Michael Walle <michael@walle.cc> writes:
> Am 2022-08-09 09:57, schrieb Ajay.Kathat@microchip.com:
>> Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an
>> object on the stack. Use dynamically allocated memory for cmd53 instead
>> of stack address which is not DMA'able.
>>
>> Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging")
>> Reported-by: Michael Walle <mwalle@kernel.org>
>> Suggested-by: Michael Walle <mwalle@kernel.org>
>> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
>
> Thanks!
>
> Reviewed-by: Michael Walle <mwalle@kernel.org>
> Tested-by: Michael Walle <mwalle@kernel.org>
Thanks Michael. My plan is to take this to the wireless tree, seems
important enough fix.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-08-11 4:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 7:57 [PATCH v3] wifi: wilc1000: fix DMA on stack objects Ajay.Kathat
2022-08-10 12:07 ` Michael Walle
2022-08-11 4:55 ` Kalle Valo [this message]
2022-08-22 7:27 ` Michael Walle
2022-08-29 16:06 ` Kalle Valo
2022-08-30 16:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k07fgz16.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Sripad.Balwadgi@microchip.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mwalle@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).