From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: nbd@nbd.name, sgruszka@redhat.com,
linux-wireless@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] mt76: fix building without CONFIG_LEDS_CLASS
Date: Mon, 05 Nov 2018 16:54:40 +0200 [thread overview]
Message-ID: <87k1lrfubz.fsf@codeaurora.org> (raw)
In-Reply-To: <20181102132006.GA27823@localhost.localdomain> (Lorenzo Bianconi's message of "Fri, 2 Nov 2018 14:20:07 +0100")
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
>> Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
>>
>> > From: Arnd Bergmann <arnd@arndb.de>
>> >
>> > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while
>> > mt76 is built-in, we run into a link error:
>> >
>> > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_register_device':
>> > mac80211.c:(.text+0xb78): relocation truncated to fit:
>> > R_AARCH64_CALL26 against undefined symbol
>> > `devm_of_led_classdev_register'
>> >
>> > We don't really need a hard dependency here as the driver can presumably
>> > work just fine without LEDs, so this follows the iwlwifi example and
>> > adds a separate Kconfig option for the LED support, this will be available
>> > whenever it will link, and otherwise the respective code gets left out from
>> > the driver object.
>> >
>> > Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>>
>> Should this go to 4.20? A linker error is pretty bad, even though I
>> think this is few months old issue already.
>
> I guess so. The patch is based on top of Felix's repository so it apply with a
> 'fuzz' on net-next/wireless-drivers-next but the patch is ok. Do I need to
> resend or it is ok?
Doesn't seem to apply to wireless-drivers (which I fast forwarded to
v4.20-rc1 today):
Failed to apply the patch: ['git', 'am', '-s', '-3'] failed: 128
fatal: sha1 information is lacking or useless (drivers/net/wireless/mediatek/mt76/mt76x2/pci_init.c).
error: could not build fake ancestor
So please rebase and resend.
--
Kalle Valo
prev parent reply other threads:[~2018-11-05 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1541150589.git.lorenzo.bianconi@redhat.com>
2018-11-02 9:32 ` [PATCH] mt76: fix building without CONFIG_LEDS_CLASS Lorenzo Bianconi
2018-11-02 11:33 ` Kalle Valo
2018-11-02 13:20 ` Lorenzo Bianconi
2018-11-05 14:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1lrfubz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).