From: Kalle Valo <kvalo@codeaurora.org>
To: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Subject: Re: [PATCH 05/11] rsi: handle station connection in AP mode
Date: Mon, 14 Aug 2017 07:54:42 +0300 [thread overview]
Message-ID: <87k226da0d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1502458889-9690-6-git-send-email-amitkarwar@gmail.com> (Amitkumar Karwar's message of "Fri, 11 Aug 2017 19:11:23 +0530")
Amitkumar Karwar <amitkarwar@gmail.com> writes:
> From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
>
> Station structures are maintained in driver with required
> fields. When mac80211 callback sta_add is called, driver
> iterates through list of connected stations to check available
> index and assigns station id which is important for further
> communication to that station. Then peer notify frame is send
> to firmware to inform the firmware about new station connection.
>
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
[...]
> @@ -1157,18 +1159,81 @@ static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
> {
> struct rsi_hw *adapter = hw->priv;
> struct rsi_common *common = adapter->priv;
> + bool sta_exist = false;
> + struct rsi_sta *rsta;
> +
> + print_hex_dump(KERN_INFO, "Station add: ", DUMP_PREFIX_OFFSET,
> + 16, 1, sta->addr, ETH_ALEN, 0);
The driver should not spam the logs every time a client connects, so
this should be a debug message.
--
Kalle Valo
next prev parent reply other threads:[~2017-08-14 4:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 13:41 [PATCH 00/11] rsi: support for AP mode Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 01/11] rsi: advertise ap mode support Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 02/11] rsi: add interface changes for ap mode Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 03/11] rsi: remove interface changes for AP mode Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 04/11] rsi: add beacon " Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 05/11] rsi: handle station connection in " Amitkumar Karwar
2017-08-14 4:54 ` Kalle Valo [this message]
2017-08-14 6:53 ` Prameela Rani Garnepudi
2017-08-14 19:10 ` Arend van Spriel
2017-08-15 7:20 ` Kalle Valo
2017-08-16 6:41 ` Prameela Rani Garnepudi
2017-08-11 13:41 ` [PATCH 06/11] rsi: handle station disconnection " Amitkumar Karwar
2017-08-14 4:55 ` Kalle Valo
2017-08-11 13:41 ` [PATCH 07/11] rsi: data and managemet path changes for " Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 08/11] rsi: use common descriptor for auto rate frame Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 09/11] rsi: update tx auto rate command frame for AP mode Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 10/11] rsi: aggregation parameters " Amitkumar Karwar
2017-08-11 13:41 ` [PATCH 11/11] rsi: security enhancements " Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k226da0d.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=amit.karwar@redpinesignals.com \
--cc=amitkarwar@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).