From: Kalle Valo <kvalo@codeaurora.org>
To: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: linux-wireless@vger.kernel.org, hofrat@osadl.org,
xypron.glpk@gmx.de, prameela.garnepudi@redpinesignals.com
Subject: Re: [PATCH] rsi: update in vap_capabilities frame to device
Date: Wed, 12 Oct 2016 17:29:13 +0300 [thread overview]
Message-ID: <87k2ddej46.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1474885981-6810-1-git-send-email-prameela.j04cs@gmail.com> (Prameela Rani Garnepudi's message of "Mon, 26 Sep 2016 16:03:01 +0530")
Prameela Rani Garnepudi <prameela.j04cs@gmail.com> writes:
> added vap status(add/delete) field in vap capabilities frame to device
> added sending vap capabilites frame(with vap status 'delete') in remove interface
>
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Why? How is this better now? I'm sure there is a good reason why you add
this but we don't know as the commit tells nothing we don't already know
just from looking at the patch.
The most important part of commit log is to answer the question "Why?",
not "What?".
> rsi_dbg(ERR_ZONE,
> - "%s: Interface type %d not supported\n", __func__,
> - vif->type);
> + "%s: Interface type %d not supported\n",
> + __func__, vif->type);
Unnecessary style change, please drop.
> - rsi_dbg(MGMT_TX_ZONE, "%s: Sending VAP capabilities frame\n", __func__);
> + rsi_dbg(MGMT_TX_ZONE,
> + "%s: Sending VAP capabilities frame\n", __func__);
Same here.
--
Kalle Valo
next prev parent reply other threads:[~2016-10-12 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 10:33 [PATCH] rsi: update in vap_capabilities frame to device Prameela Rani Garnepudi
2016-10-12 14:29 ` Kalle Valo [this message]
2016-10-12 14:39 ` Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ddej46.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=hofrat@osadl.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.garnepudi@redpinesignals.com \
--cc=prameela.j04cs@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).