From: Kalle Valo <kvalo@codeaurora.org>
To: Baole Ni <baolex.ni@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0768/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 02 Aug 2016 20:52:15 +0300 [thread overview]
Message-ID: <87k2fz5a9c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160802114428.860-1-baolex.ni@intel.com> (Baole Ni's message of "Tue, 2 Aug 2016 19:44:28 +0800")
(Trimming CC)
Baole Ni <baolex.ni@intel.com> writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Over 1000 patches? It's totally inapproriate to spam people's inboxes
(including mine) like this. PLEASE first study how kernel development
works and then start with something small, not like this.
I'm dropping all patches from this patchset.
--
Kalle Valo
next prev parent reply other threads:[~2016-08-02 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 11:44 [PATCH 0768/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 17:52 ` Kalle Valo [this message]
2016-08-02 18:34 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2fz5a9c.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=baolex.ni@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox