From: Kalle Valo <kvalo@codeaurora.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, <stable@vger.kernel.org>
Subject: Re: [PATCH 01/21] iwlwifi: dvm: fix WoWLAN
Date: Thu, 07 Jan 2016 23:15:35 +0200 [thread overview]
Message-ID: <87k2nljdl4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1452170861-10060-1-git-send-email-emmanuel.grumbach@intel.com> (Emmanuel Grumbach's message of "Thu, 7 Jan 2016 14:47:21 +0200")
Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
> My commit below introduced a mutex in the transport to
> prevent concurrent operations. To do so, it added a flag
> (is_down) to make sure the transport is in the right state.
> This uncoverred an bug that didn't cause any harm until
> now: iwldvm calls stop_device and then starts the firmware
> without calling start_hw in between. While this flow is
> fine from the device configuration point of view (register,
> etc...), it is now forbidden by the new is_down flag.
> This led to this error to appear:
> iwlwifi 0000:05:00.0: Can't start_fw since the HW hasn't been started
> and the suspend would fail.
>
> This fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=109591
>
> CC: <stable@vger.kernel.org> [4.3+]
> Reported-by: Bogdan Bogush <bogdan.s.bogush@gmail.com>
> Fixes=fa9f3281cbb1 ("iwlwifi: pcie: lock start_hw / start_fw / stop_device")
No need to change this anymore, but this should be:
Fixes: fa9f3281cbb1 ("iwlwifi: pcie: lock start_hw / start_fw / stop_device")
--
Kalle Valo
next prev parent reply other threads:[~2016-01-07 21:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 12:46 pull request: iwlwifi-next 2016-01-07 Grumbach, Emmanuel
2016-01-07 12:47 ` [PATCH 01/21] iwlwifi: dvm: fix WoWLAN Emmanuel Grumbach
2016-01-07 21:15 ` Kalle Valo [this message]
2016-01-08 8:08 ` Grumbach, Emmanuel
2016-01-07 12:47 ` [PATCH 02/21] iwlwifi: update and fix 7265 series PCI IDs Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 03/21] iwlwifi: mvm: let the firmware choose the antenna for beacons Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 04/21] iwlwifi: mvm: change mcc update API Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 05/21] iwlwifi: mvm: reset mvm->scan_type when firmware is started Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 06/21] iwlwifi: set max firmware version of 7265 to 17 Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 07/21] iwlwifi: mvm: bump max API to 20 Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 08/21] iwlwifi: nvm: fix loading default NVM file Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 09/21] iwlwifi: mvm: fix extended dwell time Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 10/21] iwlwifi: mvm: dump the radio registers when the firmware crashes Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 11/21] iwlwifi: mvm: add a non-trigger window to fw dbg triggers Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 12/21] iwlwifi: mvm: support A-MSDU in A-MPDU Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 13/21] iwlwifi: mvm: remove useless WARN_ON and rely on cfg80211's combination Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 14/21] iwlwifi: mvm: prevent multiple stations with the same address Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 15/21] iwlwifi: mvm: don't ask beacons when P2P GO vif and no assoc sta Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 16/21] iwlwifi: mvm: check PN for CCMP/GCMP in the driver Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 17/21] iwlwifi: mvm: initialize gtkdata->mvm correctly Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 18/21] iwlwifi: mvm: check minimum temperature notification length Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 19/21] iwlwifi: mvm: constify the parameters of a few functions in fw-dbg.c Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 20/21] iwlwifi: mvm: fix memory leaks in error paths upon fw error dump Emmanuel Grumbach
2016-01-07 12:47 ` [PATCH 21/21] iwlwifi: pcie: properly configure the debug buffer size for 8000 Emmanuel Grumbach
2016-01-07 17:05 ` pull request: iwlwifi-next 2016-01-07 Grumbach, Emmanuel
2016-01-07 21:08 ` Kalle Valo
2016-01-08 8:12 ` Grumbach, Emmanuel
2016-01-08 8:42 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2nljdl4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).