* [PATCH] ath6kl: Don't print error message when recv is canceled
@ 2015-11-18 22:51 Steve deRosier
2015-12-08 14:56 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Steve deRosier @ 2015-11-18 22:51 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath6kl, linux-wireless, Steve deRosier
An error message ath6kl_htc_rxmsg_pending_handler isn't appropate for when
the error is ECANCELED. This could be the result of a perfectly appropriate
RX cancel due to shutdown or suspend. This allows the right cleanup to
continue, but without an alarming error message in this particular case.
Signed-off-by: Steve deRosier <steve.derosier@lairdtech.com>
---
drivers/net/wireless/ath/ath6kl/htc_mbox.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/htc_mbox.c b/drivers/net/wireless/ath/ath6kl/htc_mbox.c
index fffb65b..65c31da 100644
--- a/drivers/net/wireless/ath/ath6kl/htc_mbox.c
+++ b/drivers/net/wireless/ath/ath6kl/htc_mbox.c
@@ -2222,8 +2222,9 @@ int ath6kl_htc_rxmsg_pending_handler(struct htc_target *target,
}
if (status) {
- ath6kl_err("failed to get pending recv messages: %d\n",
- status);
+ if (status != -ECANCELED)
+ ath6kl_err("failed to get pending recv messages: %d\n",
+ status);
/* cleanup any packets in sync completion queue */
list_for_each_entry_safe(packets, tmp_pkt, &comp_pktq, list) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath6kl: Don't print error message when recv is canceled
2015-11-18 22:51 [PATCH] ath6kl: Don't print error message when recv is canceled Steve deRosier
@ 2015-12-08 14:56 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-12-08 14:56 UTC (permalink / raw)
To: Steve deRosier; +Cc: ath6kl, linux-wireless, Steve deRosier
Steve deRosier <derosier@gmail.com> writes:
> An error message ath6kl_htc_rxmsg_pending_handler isn't appropate for when
> the error is ECANCELED. This could be the result of a perfectly appropriate
> RX cancel due to shutdown or suspend. This allows the right cleanup to
> continue, but without an alarming error message in this particular case.
>
> Signed-off-by: Steve deRosier <steve.derosier@lairdtech.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-08 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 22:51 [PATCH] ath6kl: Don't print error message when recv is canceled Steve deRosier
2015-12-08 14:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).