Re: [PATCH] ath10k: unify warning messages in mac.c

[Kalle Valo <kvalo@qca.qualcomm.com>]

Kalle Valo <kvalo@qca.qualcomm.com> writes:

>> I think we should agree on one of the two approaches:
>>
>> a) start with a verb:
>>
>> "failed to add peer %pM on vdev %i: %d"
>> "failed to initialize dfs pattern detector"
>> "timed out while waiting for scan completion"
>>
>> b) start with a noun:
>>
>> "peer %pM on vdev %i could not be added: %d"
>> "dfs pattern detector could not initialize"
>> "scan timed out"
>>
>> These are still mixed.
>>
>> We could probably also limit the set of verbs, e.g. replace "could
>> not" with "failed to" as it's practically the same thing (assuming we
>> pick (a)).
>
> That's true. I would vote for option (a).

I didn't get any comments about Michal's proposal. Can I conclude from
this that (a) above is ok for everyone?

-- 
Kalle Valo