From: Kalle Valo <kalle.valo@iki.fi>
To: Christian Lamparter <chunkeey@web.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] p54spi: fix build dependencies
Date: Fri, 16 Jan 2009 21:33:43 +0200 [thread overview]
Message-ID: <87k58vxcyw.fsf@litku.valot.fi> (raw)
In-Reply-To: <200901161929.30204.chunkeey@web.de> (Christian Lamparter's message of "Fri\, 16 Jan 2009 19\:29\:29 +0100")
Christian Lamparter <chunkeey@web.de> writes:
>> p54spi only depends on SPI_MASTER, but includes arm-specific files.
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> ---
> diff --git a/drivers/net/wireless/p54/Kconfig b/drivers/net/wireless/p54/Kconfig
> index cfc5f41..131dba3 100644
> --- a/drivers/net/wireless/p54/Kconfig
> +++ b/drivers/net/wireless/p54/Kconfig
> @@ -64,7 +64,8 @@ config P54_PCI
>
> config P54_SPI
> tristate "Prism54 SPI (stlc45xx) support"
> - depends on P54_COMMON && SPI_MASTER
> + depends on P54_COMMON && SPI_MASTER && ARCH_OMAP && \
> + (MACH_NOKIA_N800 || MACH_NOKIA_N810)
N800 and N810 support is not on mainline yet, for stlc45xx I decided
to add module parameters for the gpio numbers. Here's the commit from
stlc45xx repo:
http://gitorious.org/projects/stlc45xx/repos/mainline/commits/35afc5df0027d02d49e6f5bf986dcc4deb4ee6cf
After that the driver is generic and should compile everywhere.
omap_get_config() is deprecated anyway, we should use proper
platform_data instead.
--
Kalle Valo
next prev parent reply other threads:[~2009-01-16 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1LNgyq-0006iZ-0M@sipsolutions.net>
2009-01-16 9:30 ` p54 build failure Johannes Berg
2009-01-16 18:29 ` [PATCH] p54spi: fix build dependencies Christian Lamparter
2009-01-16 19:33 ` Kalle Valo [this message]
2009-01-16 21:34 ` [PATCH] p54spi: remove arch specific dependencies Christian Lamparter
2009-01-17 8:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k58vxcyw.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).