From: Elias Oltmanns <eo@nebensachen.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Slaby <jirislaby@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: ath5k: kernel timing screwed - due to unserialised register access?
Date: Sat, 11 Oct 2008 22:30:17 +0200 [thread overview]
Message-ID: <87k5ceeuxy.fsf@denkblock.local> (raw)
In-Reply-To: alpine.LFD.2.00.0810111149420.3356@apollo
Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 10 Oct 2008, Thomas Gleixner wrote:
>> On Fri, 10 Oct 2008, Elias Oltmanns wrote:
[...]
>> > This particular one is in
>> > drivers/net/wireless/ath5k/phy.c:ath5k_hw_noise_floor_calibration()
>> > which is called from ath5k_calibrate(), the callback executed every ten
>> > seconds in softirq context. Could this have anything to do with our
>>
>> That makes sense. The timer expires early events are multiples of 10s
>> apart.
>
> Ok, I thought more about it and aside of the fact that the ath5k is
> doing something nasty, you unearthed a weakness in the broadcast code.
>
> Can you please try the following:
>
> Compile the acpi_processor module in to the kernel
> (CONFIG_ACPI_PROCESSOR=y) and add processor.max_cstate=1 to the kernel
> command line. If I analysed the problem correctly this will make the
> jiffies problem go away. I'm working on a fix.
Spot on, it does go away regardless whether NO_HZ or HIGH_RES are
enabled or disabled. Looking forward to testing your fix ;-).
Regards,
Elias
next prev parent reply other threads:[~2008-10-11 20:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-05 21:45 ath5k: kernel timing screwed - due to unserialised register access? Elias Oltmanns
2008-10-05 21:59 ` Thomas Gleixner
2008-10-06 14:04 ` Elias Oltmanns
2008-10-06 19:47 ` Thomas Gleixner
2008-10-07 15:27 ` Elias Oltmanns
2008-10-07 18:02 ` Thomas Gleixner
2008-10-07 18:44 ` Thomas Gleixner
2008-10-07 21:23 ` Elias Oltmanns
2008-10-08 11:39 ` Elias Oltmanns
2008-10-08 21:14 ` Thomas Gleixner
2008-10-09 11:15 ` Thomas Gleixner
2008-10-10 8:33 ` Elias Oltmanns
2008-10-10 10:13 ` Thomas Gleixner
2008-10-10 11:50 ` Elias Oltmanns
2008-10-10 12:34 ` Thomas Gleixner
2008-10-10 12:59 ` Elias Oltmanns
2008-10-10 21:32 ` Christoph Hellwig
2008-10-11 9:55 ` Thomas Gleixner
2008-10-10 19:24 ` Nick Kossifidis
2008-10-11 9:54 ` Thomas Gleixner
2008-10-11 20:30 ` Elias Oltmanns [this message]
2008-10-14 19:00 ` Thomas Gleixner
2008-10-14 22:01 ` Elias Oltmanns
2008-10-15 8:43 ` Thomas Gleixner
2008-10-15 16:32 ` Elias Oltmanns
2008-10-15 19:53 ` Thomas Gleixner
2008-10-17 21:03 ` Elias Oltmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k5ceeuxy.fsf@denkblock.local \
--to=eo@nebensachen.de \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).