From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rosen Penev <rosenp@gmail.com>, linux-wireless@vger.kernel.org
Cc: open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] wifi: ath9k: ahb: do ioremap resource in one step
Date: Tue, 22 Apr 2025 14:35:38 +0200 [thread overview]
Message-ID: <87ldrsjrvp.fsf@toke.dk> (raw)
In-Reply-To: <20250421040044.44887-1-rosenp@gmail.com>
Rosen Penev <rosenp@gmail.com> writes:
> Simplifies probe slightly and adds extra error codes.
>
> Switching from devm_ioremap to the platform variant ends up calling
> devm_request_mem_region, which reserves the memory region for the
> various wmacs. Per board, there is only one wmac and after some fairly
> thorough analysis, there are no overlapping memory regions between wmacs
> and other devices on the ahb.
>
> Tested on a TP-Link Archer C7v2.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> v2: remove wrong devm irq conversion.
> drivers/net/wireless/ath/ath9k/ahb.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
Is there any benefit from this other than code simplification? Because,
TBH, I'm not sure saving 7 lines of code is worth the risk of changing
something we know works already...
-Toke
next prev parent reply other threads:[~2025-04-22 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 4:00 [PATCHv2] wifi: ath9k: ahb: do ioremap resource in one step Rosen Penev
2025-04-22 12:35 ` Toke Høiland-Jørgensen [this message]
2025-04-22 21:34 ` Rosen Penev
2025-05-01 16:20 ` Toke Høiland-Jørgensen
2025-05-02 9:29 ` Toke Høiland-Jørgensen
2025-05-16 17:40 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldrsjrvp.fsf@toke.dk \
--to=toke@toke.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).