From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-wireless@vger.kernel.org, kvalo@kernel.org, nbd@nbd.name,
yangshiji66@outlook.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath9k: return by of_get_mac_address
Date: Wed, 02 Oct 2024 10:51:50 +0200 [thread overview]
Message-ID: <87ldz6q449.fsf@toke.dk> (raw)
In-Reply-To: <CAKxU2N9XFJZaVJgQDVNWmsUoJ_WTHdv7ViTs9xFpFWKeY5Woaw@mail.gmail.com>
Rosen Penev <rosenp@gmail.com> writes:
> On Tue, Oct 1, 2024 at 1:27 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> Rosen Penev <rosenp@gmail.com> writes:
>>
>> > It can return -EPROBE_DEFER when using NVMEM. return it so that it gets
>> > forwarded to _init.
>>
>> What bug, if any, does this fix?
> None that I've seen. But the goal is: if ath9k probes before NVMEM,
> defer so that it can get an NVMEM mac address properly.
>
> I think in OpenWrt there are hacks that force ath9k to probe later, I
> think because of the GPIO driver situation there.
Right. Please include this rationale in the patch description :)
-Toke
prev parent reply other threads:[~2024-10-02 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 23:04 [PATCH] wifi: ath9k: return by of_get_mac_address Rosen Penev
2024-10-01 8:27 ` Toke Høiland-Jørgensen
2024-10-01 18:49 ` Rosen Penev
2024-10-02 8:51 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldz6q449.fsf@toke.dk \
--to=toke@toke.dk \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=rosenp@gmail.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).