* [PATCH] wifi: ath9k: return by of_get_mac_address
@ 2024-09-30 23:04 Rosen Penev
2024-10-01 8:27 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: Rosen Penev @ 2024-09-30 23:04 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, toke, nbd, yangshiji66, linux-kernel
It can return -EPROBE_DEFER when using NVMEM. return it so that it gets
forwarded to _init.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/wireless/ath/ath9k/init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index f9e77c4624d9..8924d49fd8b5 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -647,9 +647,7 @@ static int ath9k_of_init(struct ath_softc *sc)
ah->ah_flags |= AH_NO_EEP_SWAP;
}
- of_get_mac_address(np, common->macaddr);
-
- return 0;
+ return of_get_mac_address(np, common->macaddr);
}
static int ath9k_init_softc(u16 devid, struct ath_softc *sc,
--
2.46.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath9k: return by of_get_mac_address
2024-09-30 23:04 [PATCH] wifi: ath9k: return by of_get_mac_address Rosen Penev
@ 2024-10-01 8:27 ` Toke Høiland-Jørgensen
2024-10-01 18:49 ` Rosen Penev
0 siblings, 1 reply; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2024-10-01 8:27 UTC (permalink / raw)
To: Rosen Penev, linux-wireless; +Cc: kvalo, nbd, yangshiji66, linux-kernel
Rosen Penev <rosenp@gmail.com> writes:
> It can return -EPROBE_DEFER when using NVMEM. return it so that it gets
> forwarded to _init.
What bug, if any, does this fix?
-Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath9k: return by of_get_mac_address
2024-10-01 8:27 ` Toke Høiland-Jørgensen
@ 2024-10-01 18:49 ` Rosen Penev
2024-10-02 8:51 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: Rosen Penev @ 2024-10-01 18:49 UTC (permalink / raw)
To: Toke Høiland-Jørgensen
Cc: linux-wireless, kvalo, nbd, yangshiji66, linux-kernel
On Tue, Oct 1, 2024 at 1:27 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> Rosen Penev <rosenp@gmail.com> writes:
>
> > It can return -EPROBE_DEFER when using NVMEM. return it so that it gets
> > forwarded to _init.
>
> What bug, if any, does this fix?
None that I've seen. But the goal is: if ath9k probes before NVMEM,
defer so that it can get an NVMEM mac address properly.
I think in OpenWrt there are hacks that force ath9k to probe later, I
think because of the GPIO driver situation there.
>
> -Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath9k: return by of_get_mac_address
2024-10-01 18:49 ` Rosen Penev
@ 2024-10-02 8:51 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2024-10-02 8:51 UTC (permalink / raw)
To: Rosen Penev; +Cc: linux-wireless, kvalo, nbd, yangshiji66, linux-kernel
Rosen Penev <rosenp@gmail.com> writes:
> On Tue, Oct 1, 2024 at 1:27 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> Rosen Penev <rosenp@gmail.com> writes:
>>
>> > It can return -EPROBE_DEFER when using NVMEM. return it so that it gets
>> > forwarded to _init.
>>
>> What bug, if any, does this fix?
> None that I've seen. But the goal is: if ath9k probes before NVMEM,
> defer so that it can get an NVMEM mac address properly.
>
> I think in OpenWrt there are hacks that force ath9k to probe later, I
> think because of the GPIO driver situation there.
Right. Please include this rationale in the patch description :)
-Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-02 8:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 23:04 [PATCH] wifi: ath9k: return by of_get_mac_address Rosen Penev
2024-10-01 8:27 ` Toke Høiland-Jørgensen
2024-10-01 18:49 ` Rosen Penev
2024-10-02 8:51 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).