From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 398D320B3E for ; Tue, 21 May 2024 08:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716278444; cv=none; b=HpRS7sDQJOjCInntZn0nFp6T9rOLs+177LuGG9IeOd4CFEqyXK/n9c/VMQCRozBjHtv91ZeNurKqXTWLu3F+hNzEYNG+Djif+Pp9T0NGwanK95/SRPR9ogzpZX6WSIUDutLsdIg4I/b2GVjCFHnNWSJ9+PFvTRG/O4X+s7jVEUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716278444; c=relaxed/simple; bh=OFGokqz3ADKTizuCIWhcKw3hIa9Kg9nWRnUd34o2hHU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=JFv5sDTW9Qi5nHJ6CMjseSqOAVZBZhlZY5nOvZZoLTb2LPqJIQ0q5x0hxzjNAx+Ntwz79LS+7SCKT5+vrIiyWrvsCS1hsCCfec9xOvsV61UVmN0xjj8e/5hHOXsH6m4GL73kOYJlUjuBuW/AQsk6BBQOo5eO6TZdH5gTcjCyohc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LKOKV/u5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LKOKV/u5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D5B7C2BD11; Tue, 21 May 2024 08:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716278443; bh=OFGokqz3ADKTizuCIWhcKw3hIa9Kg9nWRnUd34o2hHU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LKOKV/u5wsZVOaPoytUYbO9mB4UKj21WtYUvZVsafG5ZAk63Anxtvu7d1dxm2r4jd qKXwWo49iN9v2vLHFH6Wg0PtmCP5eI9oRCdmo6imlT3fh2KqrIWTxWWfuXWab/RI1o awLAsjy/BR9XdIkZXoxjmORgrhnUGqsfwiS1oyOY//e7HjbppJbaR2BkVERAx5E+fN i+FwjCD2zzUh9zKT2YkGSQb2WhGdSohC//xhiB+GhMj1k2wEI8UYK/G0mA5CAPMNhD USu66fprpKRPwc8eqgI+kV9F1DBXxl2Qc5a5FdiXjGk5TQr6vJfENmklnl4pEOquEO Sv6Q0jV0UY0TA== From: Kalle Valo To: Ramya Gnanasekar Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 5/5] wifi: ath12k: Dump additional Tx PDEV HTT stats References: <20240510050806.514126-1-quic_rgnanase@quicinc.com> <20240510050806.514126-6-quic_rgnanase@quicinc.com> Date: Tue, 21 May 2024 11:00:41 +0300 In-Reply-To: <20240510050806.514126-6-quic_rgnanase@quicinc.com> (Ramya Gnanasekar's message of "Fri, 10 May 2024 10:38:06 +0530") Message-ID: <87le43d26u.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ramya Gnanasekar writes: > Support to dump additional Tx PDEV stats through HTT stats debugfs. > Following stats dump are supported: > 1. PDEV control path stat to dump Tx management frame count > 2. Tx PDEV SIFS histogram stats > 3. Tx MU MIMO PPDU stats for 802.11ac, 802.11ax and 802.11be > > Sample Output: > -------------- > echo 1 > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats_type > cat /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats > HTT_TX_PDEV_STATS_CMN_TLV: > mac_id = 0 > comp_delivered = 0 > self_triggers = 13 > ...... > ...... > HTT_TX_PDEV_STATS_CTRL_PATH_TX_STATS: > fw_tx_mgmt_subtype = 0:1, 1:0, 2:0, 3:0, 4:38, 5:0, 6:0, 7:0, 8:0, 9:0, 10:0, 11:1, 12:0, 13:7, 14:0, 15:0, > > HTT_TX_PDEV_STATS_SIFS_HIST_TLV: > sifs_hist_status = 0:237, 1:185, 2:1, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > > HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS: > ac_mu_mimo_num_seq_posted_nr4 = 0 > ac_mu_mimo_num_ppdu_posted_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ac_mu_mimo_num_ppdu_completed_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ac_mu_mimo_num_seq_term_status_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, > > ac_mu_mimo_num_seq_posted_nr8 = 0 > ac_mu_mimo_num_ppdu_posted_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ac_mu_mimo_num_ppdu_completed_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ac_mu_mimo_num_seq_term_status_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, > > ax_mu_mimo_num_seq_posted_nr4 = 0 > ax_mu_mimo_num_ppdu_posted_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ax_mu_mimo_num_ppdu_completed_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ax_mu_mimo_num_seq_term_status_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, > > ax_mu_mimo_num_seq_posted_nr8 = 0 > ax_mu_mimo_num_ppdu_posted_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ax_mu_mimo_num_ppdu_completed_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > ax_mu_mimo_num_seq_term_status_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, > > be_mu_mimo_num_seq_posted_nr4 = 0 > be_mu_mimo_num_ppdu_posted_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > be_mu_mimo_num_ppdu_completed_per_burst_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > be_mu_mimo_num_seq_term_status_nr4 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, > > be_mu_mimo_num_seq_posted_nr8 = 0 > be_mu_mimo_num_ppdu_posted_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > be_mu_mimo_num_ppdu_completed_per_burst_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, 9:0, > be_mu_mimo_num_seq_term_status_nr8 = 0:0, 1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:0, > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Ramya Gnanasekar [...] > +static inline void > +ath12k_htt_print_tx_pdev_mu_ppdu_dist_stats_tlv(const void *tag_buf, > + struct debug_htt_stats_req *stats_req) > +{ > + const struct ath12k_htt_tx_pdev_mu_ppdu_dist_stats_tlv *htt_stats_buf = tag_buf; > + char *mode; > + u8 j, hw_mode, i, str_buf_len; > + u8 *buf = stats_req->buf; > + u32 len = stats_req->buf_len; > + u32 buf_len = ATH12K_HTT_STATS_BUF_SIZE; > + u32 stats_value; > + u8 max_ppdu = ATH12K_HTT_STATS_MAX_NUM_MU_PPDU_PER_BURST; > + u8 max_sched = ATH12K_HTT_STATS_MAX_NUM_SCHED_STATUS; > + char str_buf[ATH12K_HTT_MAX_STRING_LEN]; > + > + hw_mode = le32_to_cpu(htt_stats_buf->hw_mode); > + > + switch (hw_mode) { > + case ATH12K_HTT_STATS_HWMODE_AC: > + len += scnprintf(buf + len, buf_len - len, > + "HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:\n"); > + mode = "ac"; > + break; > + case ATH12K_HTT_STATS_HWMODE_AX: > + mode = "ax"; > + break; > + case ATH12K_HTT_STATS_HWMODE_BE: > + mode = "be"; > + break; > + default: > + return; > + } Why are we not adding "HTT_TX_PDEV_MU_PPDU_DISTRIBUTION_STATS:\n" with ax and be modes? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches