From: Kalle Valo <kvalo@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI""
Date: Tue, 29 Aug 2023 14:47:27 +0300 [thread overview]
Message-ID: <87leduf4ts.fsf@kernel.org> (raw)
In-Reply-To: <ZOof7EE0tXAt0YN7@hovoldconsulting.com> (Johan Hovold's message of "Sat, 26 Aug 2023 17:53:16 +0200")
Johan Hovold <johan@kernel.org> writes:
> On Tue, Aug 22, 2023 at 03:44:45PM +0200, Johan Hovold wrote:
>> On Tue, Aug 22, 2023 at 03:56:24PM +0300, Kalle Valo wrote:
>> > Johan Hovold <johan@kernel.org> writes:
>> > > On Wed, Aug 09, 2023 at 09:34:32AM +0200, Johan Hovold wrote:
>> > >
>> > >> Disabling threaded NAPI caused a severe regression in 6.5-rc5 by making
>> > >> the X13s completely unusable (e.g. no keyboard input, I've seen an RCU
>> > >> splat once).
>>
>> > > Any chance we can get the offending commit reverted before 6.5 is
>> > > released?
>> >
>> > The problem here is that would break QCN9074 again so there is no good
>> > solution. I suspect we have a fundamental issue in ath11k which we just
>> > haven't discovered yet. I would prefer to get to the bottom of this
>> > before reverting anything.
>>
>> Sure, ideally we can find and fix the underlying issues these next few
>> days, but since this regression was introduced in rc5 in an attempt to
>> address the QCN9074 issue which has been there since 6.1 I think we
>> need to revert otherwise.
>
> I've managed to track down what causes the hang on the X13s after
> disabling threaded NAPI. Turns out to be a severe regression in the
> genirq code that causes the software resend tasklet to loop
> indefinitely.
>
> I've just sent a fix here:
>
> https://lore.kernel.org/lkml/20230826154004.1417-1-johan+linaro@kernel.org/
Oh wow, that's a tricky bug :o I'm sure it was not easy to find.
> I've also made some progress on the QCN9074 hang, but keeping the
> threaded NAPI revert for now is indeed the right thing to do.
Ok, thanks for the update and looking at also this problem. Very much
appreciated! I'm sure we have a major bug lurking somewhere in ath11k,
would be so good to fix that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-08-29 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 7:34 [PATCH] Revert "Revert "wifi: ath11k: Enable threaded NAPI"" Johan Hovold
2023-08-09 9:02 ` Manikanta Pubbisetty
2023-08-09 9:16 ` Johan Hovold
2023-08-10 4:33 ` Manikanta Pubbisetty
2023-08-21 13:27 ` Johan Hovold
2023-08-10 4:46 ` Manikanta Pubbisetty
2023-08-21 13:29 ` Johan Hovold
2023-08-21 13:41 ` Johan Hovold
2023-08-22 12:56 ` Kalle Valo
2023-08-22 13:44 ` Johan Hovold
2023-08-26 15:53 ` Johan Hovold
2023-08-29 11:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leduf4ts.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_mpubbise@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).