From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Dmitry Antipov <dmantipov@yandex.ru>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
Dmitriy Antipov <Dmitriy.Antipov@softline.com>
Subject: Re: [PATCH] wifi: rtlwifi: remove unused timer and related code
Date: Thu, 01 Jun 2023 08:46:34 +0300 [thread overview]
Message-ID: <87leh3ka4l.fsf@kernel.org> (raw)
In-Reply-To: <6c9982b9f48e41c4ba4f3528cb5489fd@realtek.com> (Ping-Ke Shih's message of "Thu, 1 Jun 2023 05:10:36 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: Dmitry Antipov <dmantipov@yandex.ru>
>> Sent: Thursday, June 1, 2023 12:24 PM
>> To: Ping-Ke Shih <pkshih@realtek.com>
>> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org;
>> Dmitry Antipov <dmantipov@yandex.ru>;
>> Dmitriy Antipov <Dmitriy.Antipov@softline.com>
>> Subject: [PATCH] wifi: rtlwifi: remove unused timer and related code
>
> Should increase version number such as v2, v3, ... for newer one.
And also always include a changelog, see the wiki link below for more.
> Checkpatch warns this patch:
>
> ERROR: Missing Signed-off-by: line by nominal patch author
> 'Dmitry Antipov <dmantipov@yandex.ru>'
Yeah, From and s-o-b need to always match.
> Maybe, you can adjust your s-o-b to e-mail address of "From".
It's also possible to add a second From field to the body of the
message. Here's an example how I do it when I use kernel.org to submit
my patches:
https://patchwork.kernel.org/project/linux-wireless/patch/20230530141813.29333-3-kvalo@kernel.org/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-06-01 5:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 14:30 [PATCH] rtlwifi: remove unused timer and related code Dmitry Antipov
2023-06-01 1:36 ` Ping-Ke Shih
2023-06-01 4:19 ` Dmitry Antipov
2023-06-01 4:23 ` [PATCH] wifi: " Dmitry Antipov
2023-06-01 5:10 ` Ping-Ke Shih
2023-06-01 5:46 ` Kalle Valo [this message]
2023-06-01 8:17 ` [PATCH] [v3] " Dmitry Antipov
2023-06-01 8:23 ` Ping-Ke Shih
2023-06-01 8:31 ` [PATCH] [v4] " Dmitry Antipov
2023-06-01 8:39 ` Ping-Ke Shih
2023-06-01 8:51 ` [PATCH] [v5] " Dmitry Antipov
2023-06-01 12:28 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leh3ka4l.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Dmitriy.Antipov@softline.com \
--cc=dmantipov@yandex.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).