linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
	"Ping-Ke Shih" <pkshih@realtek.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"tony0620emma@gmail.com" <tony0620emma@gmail.com>
Subject: Re: wifi: rtw88: questions about adding support for RTL8723DS/RTL8723BS
Date: Wed, 24 May 2023 12:53:49 +0300	[thread overview]
Message-ID: <87lehekqc2.fsf@kernel.org> (raw)
In-Reply-To: <e2dc78fd-014a-14d1-9b4e-9ad251e1d9e1@lwfinger.net> (Larry Finger's message of "Thu, 18 May 2023 13:48:28 -0500")

Larry Finger <Larry.Finger@lwfinger.net> writes:

>>>> To make rtlwifi support SDIO is another way. It seems like add a HCI is
>>>> easier than an new chip, and we can have a simple support list of rtlwifi
>>>> and rtw88 eventually, like
>>>>
>>>>          rtlwifi       rtw88
>>>> 8723BE    o
>>>> 8723BS    o?
>>>> 8723DE                  o
>>>> 8723DS                  o
>>> Per chip support matrix is:
>>> 8723BE: rtlwifi
>>> 8723BU: rtl8xxxu
>>> 8723BS: staging driver which I'd like to replace
>>> 8723DE/U/S: rtw88
>>>
>>> HCI support matrix:
>>> rtlwifi: PCIe, USB
>>> rtl8xxxu: USB
>>> rtw88: PCIe, USB and SDIO
>>>
>>> So it seems you are right: I should consider whether adding RTL8723BS
>>> support to rtw88 is the right choice.
>>
>> While rtw88 might not be best choice by above matrix, it seems to be most
>> featureful, stable and at least from what I saw, easiest to add new variants.
>>
>> I'll do a bit of experiment with rtw88 to see how hard it would be...
>>
>> Best regards,
>> Jernej
>
> Now that RTL8192CU is being handled, the USB part of rtlwifi is being
> considered for deletion. If you decide in terms of adding RTL8723BS to
> rtlwifi, please let me know.

From higher level point of view I would prefer rtlwifi going away in the
long run and the development focus be on rtl8xxxu, rtw88 and rtw89. So
if at all possible, please avoid adding new hardware support to rtlwifi.

But of course I'm not familiar with Realtek designs so please do correct
if I'm missing something :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2023-05-24  9:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 16:39 wifi: rtw88: questions about adding support for RTL8723DS/RTL8723BS Martin Blumenstingl
2023-05-17  2:05 ` Ping-Ke Shih
2023-05-18 17:00   ` Martin Blumenstingl
2023-05-18 17:13     ` Jernej Škrabec
2023-05-18 18:48       ` Larry Finger
2023-05-24  9:53         ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lehekqc2.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=pkshih@realtek.com \
    --cc=tony0620emma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).