From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: linux-wireless@vger.kernel.org, Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: Re: [PATCH v2] wifi: rtl8xxxu: gen2: Turn on the rate control
Date: Tue, 04 Oct 2022 11:23:33 +0300 [thread overview]
Message-ID: <87lepw575m.fsf@kernel.org> (raw)
In-Reply-To: <166487149459.9318.3375191834985088151.kvalo@kernel.org> (Kalle Valo's message of "Tue, 4 Oct 2022 08:18:17 +0000 (UTC)")
Kalle Valo <kvalo@kernel.org> writes:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>
>> Re-enable the function rtl8xxxu_gen2_report_connect.
>>
>> It informs the firmware when connecting to a network. This makes the
>> firmware enable the rate control, which makes the upload faster.
>>
>> It also informs the firmware when disconnecting from a network. In the
>> past this made reconnecting impossible because it was sending the
>> auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
>> (TXDESC_QUEUE_MGNT):
>>
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
>> wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out
>>
>> Probably the firmware disables the unnecessary TX queues when it
>> knows it's disconnected.
>>
>> However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
>> skb misuse in TX queue selection").
>>
>> Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconn…")
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>
> Patch applied to wireless-next.git, thanks.
>
> c5ef1cee5745 wifi: rtl8xxxu: gen2: Turn on the rate control
Please disregard the commit id, the fixes tag is incorrect so I need to
apply it again to fix it.
In commit
c5ef1cee5745 ("wifi: rtl8xxxu: gen2: Turn on the rate control")
Fixes tag
Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and
8723bu devices not reconn…")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-10-04 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 20:36 [PATCH v2] wifi: rtl8xxxu: gen2: Turn on the rate control Bitterblue Smith
2022-10-04 8:18 ` Kalle Valo
2022-10-04 8:23 ` Kalle Valo [this message]
2022-10-04 8:26 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lepw575m.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).