From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 1/3] nl80211: Add support for beacon tx mode
Date: Sat, 26 Mar 2022 10:48:23 +0200 [thread overview]
Message-ID: <87lewxnlpk.fsf@kernel.org> (raw)
In-Reply-To: <bca5ba81-7e97-9b54-be57-a40df9b0634c@quicinc.com> (Jeff Johnson's message of "Fri, 25 Mar 2022 12:18:41 -0700")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 3/24/2022 10:59 PM, Maharaja Kennadyrajan wrote:
> [...snip...]
>
>> +/**
>> + * enum nl80211_beacon_tx_mode - Beacon Tx Mode enum.
>> + * @NL80211_BEACON_STAGGERED_MODE: Used to configure beacon tx mode as
>> + * staggered mode. This is the default beacon tx mode.
>
> Documentation doesn't match the code. There is now a default mode, and
> that is, well, the default mode
But what does the default mode mean in this case? :) Please document in
detail what the driver is supposed to do in this mode.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-03-26 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 5:59 [PATCH v6 0/3] Add support to configure beacon tx mode Maharaja Kennadyrajan
2022-03-25 5:59 ` [PATCH v6 1/3] nl80211: Add support for " Maharaja Kennadyrajan
2022-03-25 7:48 ` Sven Eckelmann
2022-03-25 19:18 ` Jeff Johnson
2022-03-26 8:48 ` Kalle Valo [this message]
2022-03-25 5:59 ` [PATCH v6 2/3] mac80211: " Maharaja Kennadyrajan
2022-03-25 5:59 ` [PATCH v6 3/3] ath11k: " Maharaja Kennadyrajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lewxnlpk.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_mkenna@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).