From: Kalle Valo <kvalo@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix error check in ath9k_hw_read_revisions() for PCI devices
Date: Wed, 21 Apr 2021 12:09:34 +0300 [thread overview]
Message-ID: <87lf9cj969.fsf@codeaurora.org> (raw)
In-Reply-To: <87a6puimgu.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\= \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of "Mon, 19 Apr 2021 12:43:13 +0200")
Toke Høiland-Jørgensen <toke@redhat.com> writes:
>> When the error check in ath9k_hw_read_revisions() was added, it checked for
>> -EIO which is what ath9k_regread() in the ath9k_htc driver uses. However,
>> for plain ath9k, the register read function uses ioread32(), which just
>> returns -1 on error. So if such a read fails, it still gets passed through
>> and ends up as a weird mac revision in the log output.
>>
>> Fix this by changing ath9k_regread() to return -1 on error like ioread32()
>> does, and fix the error check to look for that instead of -EIO.
>>
>> Fixes: 2f90c7e5d094 ("ath9k: Check for errors when reading SREV register")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> Hi Kalle
>
> This patch is merged as "deferred" in patchwork - what's up with that?
Just lack of time on my part. Reviewed-by tags would help a lot :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-04-21 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 18:08 [PATCH] ath9k: Fix error check in ath9k_hw_read_revisions() for PCI devices Toke Høiland-Jørgensen
2021-04-19 10:43 ` Toke Høiland-Jørgensen
2021-04-21 9:09 ` Kalle Valo [this message]
2021-04-21 9:36 ` Toke Høiland-Jørgensen
2021-04-21 10:03 ` Lorenzo Bianconi
2021-04-22 13:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf9cj969.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).