From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 02/13] iwlwifi: pcie: fix the xtal latency value for a few qu devices
Date: Fri, 09 Oct 2020 10:35:36 +0300 [thread overview]
Message-ID: <87lfgf26nr.fsf@codeaurora.org> (raw)
In-Reply-To: <aef56fa157600b45ae8b4b7d1662fde085bf4c74.camel@coelho.fi> (Luca Coelho's message of "Thu, 08 Oct 2020 22:10:20 +0300")
Luca Coelho <luca@coelho.fi> writes:
> On Thu, 2020-10-08 at 18:47 +0300, Kalle Valo wrote:
>> Luca Coelho <luca@coelho.fi> writes:
>>
>> > From: Luca Coelho <luciano.coelho@intel.com>
>> >
>> > We were using 5 ms for some qu devices, but their xtal stabilizes
>> > much faster than that. Reduce the value to 500 ms.
>> >
>> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> > ---
>> > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>> > index 60e0640d07dc..8b97c2eb2632 100644
>> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>> > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>> > @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = {
>> > .device_family = IWL_DEVICE_FAMILY_22000,
>> > .base_params = &iwl_22000_base_params,
>> > .integrated = true,
>> > - .xtal_latency = 5000,
>> > + .xtal_latency = 500,
>> > .ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US,
>> > };
>>
>> The commit log doesn't make sense, I'll do s/5 ms/5 s/ during commit.
>
> Hmmm, indeed it doesn't make sense like that. But I actually think the
> 5 ms is correct, but the other one should be 500 microseconds.
Oh, didn't think of that. And it's too late to fix it now.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-10-09 7:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:12 [PATCH 00/13] iwlwifi: updates intended for v5.10 2020-10-08 part 2 Luca Coelho
2020-10-08 15:12 ` [PATCH 01/13] iwlwifi: pcie: fix xtal latency for 9560 devices Luca Coelho
2020-10-08 17:15 ` Kalle Valo
2020-10-08 15:12 ` [PATCH 02/13] iwlwifi: pcie: fix the xtal latency value for a few qu devices Luca Coelho
2020-10-08 15:47 ` Kalle Valo
2020-10-08 19:10 ` Luca Coelho
2020-10-09 7:35 ` Kalle Valo [this message]
2020-10-09 7:38 ` Luca Coelho
2020-10-08 15:12 ` [PATCH 03/13] iwlwifi: mvm: don't send a CSA command the firmware doesn't know Luca Coelho
2020-10-08 15:12 ` [PATCH 04/13] iwlwifi: mvm: remove memset of kek_kck command Luca Coelho
2020-10-08 15:12 ` [PATCH 05/13] iwlwifi: mvm: fix suspicious rcu usage warnings Luca Coelho
2020-10-08 15:12 ` [PATCH 06/13] iwlwifi: stats: add new api fields for statistics cmd/ntfy Luca Coelho
2020-10-08 15:12 ` [PATCH 07/13] iwlwifi: fix sar geo table initialization Luca Coelho
2020-10-08 15:12 ` [PATCH 08/13] iwlwifi: rs: align to new TLC config command API Luca Coelho
2020-10-08 15:12 ` [PATCH 09/13] iwlwifi: move PNVM implementation to common code Luca Coelho
2020-10-08 15:12 ` [PATCH 10/13] iwlwifi: add trans op to set PNVM Luca Coelho
2020-10-08 15:12 ` [PATCH 11/13] iwlwifi: pcie: implement set_pnvm op Luca Coelho
2020-10-08 15:12 ` [PATCH 12/13] iwlwifi: read and parse PNVM file Luca Coelho
2020-10-08 15:12 ` [PATCH 13/13] iwlwifi: bump FW API to 59 for AX devices Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfgf26nr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).