From: Kalle Valo <kvalo@codeaurora.org>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] net: brcmfmac: check return value of driver_for_each_device()
Date: Fri, 18 Sep 2020 17:41:48 +0300 [thread overview]
Message-ID: <87lfh7b103.fsf@codeaurora.org> (raw)
In-Reply-To: <1600429068-28003-1-git-send-email-zhangchangzhong@huawei.com> (Zhang Changzhong's message of "Fri, 18 Sep 2020 19:37:48 +0800")
+ linux-wireless
Zhang Changzhong <zhangchangzhong@huawei.com> writes:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
> variable 'ret' set but not used [-Wunused-but-set-variable]
> 1576 | int ret;
> | ^~~
>
> driver_for_each_device() has been declared with __must_check, so the
> return value should be checked.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Please cc linux-wireless on all wireless patches. Otherwise our
patchwork won't see it and I can't apply it. So please resend as v2.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
parent reply other threads:[~2020-09-18 14:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600429068-28003-1-git-send-email-zhangchangzhong@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfh7b103.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).