From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B426C433E1 for ; Wed, 19 Aug 2020 16:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DB2B20888 for ; Wed, 19 Aug 2020 16:15:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GzQZdxdt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbgHSQPI (ORCPT ); Wed, 19 Aug 2020 12:15:08 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:32187 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbgHSQPE (ORCPT ); Wed, 19 Aug 2020 12:15:04 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597853703; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=IlaHK20lHCefKdgMz6+d9AcsPr363iTgwCpdUXR1iGU=; b=GzQZdxdtk8NtFlLjLci8q1sxwMAHsSZHslvxUOZafAFnR8WiG6O32N6QFpA7gZmA+XPT9VPA 2Icb52yAEjxzp/06iKyiFNtvyEFOljwBRUz8m2zyXDLEcQQoP8sQ7m/KBzHyrGWfUx1xeLDo 7CDl/NFdMCoytsyOjX+VJC2PTns= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5f3d5007d84550423e6e4c16 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 19 Aug 2020 16:15:03 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 58F2CC433CB; Wed, 19 Aug 2020 16:15:02 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 90FADC433C6; Wed, 19 Aug 2020 16:15:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 90FADC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: John Crispin Cc: Miles Hu , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH V6 2/2] ath11k: add more HE fields into radiotap header References: <20200803145444.473810-1-john@phrozen.org> <20200803145444.473810-2-john@phrozen.org> Date: Wed, 19 Aug 2020 19:14:58 +0300 In-Reply-To: <20200803145444.473810-2-john@phrozen.org> (John Crispin's message of "Mon, 3 Aug 2020 16:54:44 +0200") Message-ID: <87lfiaipdp.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org John Crispin writes: > From: Miles Hu > > This patch adds code to parse HE fields inside ppdu TLVs. Then it adds the > populates the additional info into the ratiotap header. Also fix missing > QoS tag in native wifi mode. Finally rssi and tsf are also added. > > Signed-off-by: Miles Hu > Signed-off-by: John Crispin [...] > @@ -4522,11 +4522,14 @@ ath11k_dp_rx_mon_merg_msdus(struct ath11k *ar, > struct ieee80211_rx_status *rxs) > { > struct sk_buff *msdu, *mpdu_buf, *prev_buf; > - u32 decap_format, wifi_hdr_len; > + u32 decap_format; > struct hal_rx_desc *rx_desc; > char *hdr_desc; > u8 *dest; > struct ieee80211_hdr_3addr *wh; > + static u32 pkt_type; > + > + pkt_type++; We cannot use static non-const variables in ath11k, that would be racy. As this seems to be an unused variable I have just removed it in the pending branch. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches