* [PATCH] ath10k:mac: disassoc dbg msg after return check
@ 2019-11-11 8:30 Eduardo Abinader
2019-11-11 8:50 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Eduardo Abinader @ 2019-11-11 8:30 UTC (permalink / raw)
To: linux-wireless; +Cc: Eduardo Abinader, kvalo, ath10k
Signed-off-by: Eduardo Abinader <eduardoabinader@gmail.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 5e3450cfb07b..038d5c27bed7 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6786,13 +6786,13 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
/*
* Disassociation.
*/
- ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM disassociated\n",
- sta->addr);
-
ret = ath10k_station_disassoc(ar, vif, sta);
if (ret)
ath10k_warn(ar, "failed to disassociate station: %pM vdev %i: %i\n",
sta->addr, arvif->vdev_id, ret);
+ else
+ ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM disassociated\n",
+ sta->addr);
}
exit:
mutex_unlock(&ar->conf_mutex);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k:mac: disassoc dbg msg after return check
2019-11-11 8:30 [PATCH] ath10k:mac: disassoc dbg msg after return check Eduardo Abinader
@ 2019-11-11 8:50 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-11-11 8:50 UTC (permalink / raw)
To: Eduardo Abinader; +Cc: linux-wireless, ath10k
Eduardo Abinader <eduardoabinader@gmail.com> writes:
> Signed-off-by: Eduardo Abinader <eduardoabinader@gmail.com>
No empty commit logs, please.
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -6786,13 +6786,13 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
> /*
> * Disassociation.
> */
> - ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM disassociated\n",
> - sta->addr);
> -
> ret = ath10k_station_disassoc(ar, vif, sta);
> if (ret)
> ath10k_warn(ar, "failed to disassociate station: %pM vdev %i: %i\n",
> sta->addr, arvif->vdev_id, ret);
> + else
> + ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM disassociated\n",
> + sta->addr);
I don't understand, how is this better?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-11 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-11 8:30 [PATCH] ath10k:mac: disassoc dbg msg after return check Eduardo Abinader
2019-11-11 8:50 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).