From: Kalle Valo <kvalo@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: linux-wireless@vger.kernel.org,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Andrey Shevchenko <ashevchenko@quantenna.com>,
Sergei Maksimenko <smaksimenko@quantenna.com>
Subject: Re: [PATCH 3/6] qtnfmac: implement cfg80211 power management callback
Date: Mon, 30 Jul 2018 16:55:01 +0300 [thread overview]
Message-ID: <87lg9ssua2.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <20180531091102.28666-4-sergey.matyukevich.os@quantenna.com> (Sergey Matyukevich's message of "Thu, 31 May 2018 12:10:59 +0300")
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:
> From: Sergei Maksimenko <smaksimenko@quantenna.com>
>
> Implement set_power_mgmt() callback that forwards power saving
> settings to the device firmware.
>
> Signed-off-by: Sergei Maksimenko <smaksimenko@quantenna.com>
[...]
> @@ -922,6 +939,9 @@ struct wiphy *qtnf_wiphy_allocate(struct qtnf_bus *bus)
> if (bus->hw_info.hw_capab & QLINK_HW_CAPAB_DFS_OFFLOAD)
> qtn_cfg80211_ops.start_radar_detection = NULL;
>
> + if (!(bus->hw_info.hw_capab & QLINK_HW_CAPAB_PWR_MGMT))
> + qtn_cfg80211_ops.set_power_mgmt = NULL;
Igor already commented about this but AFAICS this breaks if there are
more than one device on the host. Upstream drivers should not have any
limit for the number of devices they support.
--
Kalle Valo
next prev parent reply other threads:[~2018-07-30 15:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 9:10 [PATCH 0/6] qtnfmac: enable more features Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 1/6] qtnfmac: implement net_device_ops callback to set MAC address Sergey Matyukevich
2018-06-27 15:54 ` [1/6] " Kalle Valo
[not found] ` <20180627155439.481E76034E@smtp.codeaurora.org>
2018-06-29 9:26 ` Sergey Matyukevich
2018-06-29 9:43 ` Kalle Valo
2018-06-29 12:03 ` Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 2/6] qtnfmac: enable source MAC address randomization support Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 3/6] qtnfmac: implement cfg80211 power management callback Sergey Matyukevich
2018-06-01 1:04 ` Igor Mitsyanko
2018-06-04 12:50 ` Sergey Matyukevich
2018-06-04 18:58 ` Igor Mitsyanko
2018-07-30 13:55 ` Kalle Valo [this message]
2018-07-30 14:12 ` Kalle Valo
2018-05-31 9:11 ` [PATCH 4/6] qtnfmac: enable multiple SSIDs scan support Sergey Matyukevich
2018-05-31 9:11 ` [PATCH 5/6] qtnfmac: add support for PTA configuration Sergey Matyukevich
2018-07-30 14:06 ` Kalle Valo
2018-07-31 11:42 ` Arend van Spriel
2018-08-01 8:23 ` Sergey Matyukevich
2018-08-04 22:19 ` Arend van Spriel
2018-08-05 15:22 ` Sergey Matyukevich
2018-08-05 21:34 ` Arend van Spriel
2018-08-01 8:25 ` Kalle Valo
2018-05-31 9:11 ` [PATCH 6/6] qtnfmac: implement basic WoWLAN support Sergey Matyukevich
2018-07-30 14:13 ` Kalle Valo
2018-07-31 9:59 ` Sergey Matyukevich
2018-08-01 8:38 ` Kalle Valo
2018-05-31 9:36 ` [PATCH 0/6] qtnfmac: enable more features Kalle Valo
2018-05-31 10:35 ` Sergey Matyukevich
2018-05-31 11:12 ` Kalle Valo
2018-06-01 1:08 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg9ssua2.fsf@qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ashevchenko@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
--cc=smaksimenko@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).