From: Kalle Valo <kvalo@codeaurora.org>
To: "Reizer\, Eyal" <eyalr@ti.com>
Cc: Eyal Reizer <eyalreizer@gmail.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"robh\@kernel.org" <robh@kernel.org>,
"sre\@kernel.org" <sre@kernel.org>,
"tony\@atomide.com" <tony@atomide.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power
Date: Thu, 26 Apr 2018 12:26:06 +0300 [thread overview]
Message-ID: <87lgda71zl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <4750eeeedcde47d39cd207a8c21ef802@ti.com> (Eyal Reizer's message of "Thu, 26 Apr 2018 08:37:35 +0000")
"Reizer, Eyal" <eyalr@ti.com> writes:
>>
>> > pm_runtime handles sdio power on and power off transitions.
>> > An old workaround for trying to control the power explicitly from the
>> > driver was in fact causing failures on suspend/resume as the mmc layer
>> > already power the module on resume.
>> >
>> > In case of resume pm_runtime_get sync returns a positive device's usage
>> > count causing the driver to try an re-initialize an already initialized
>> > device. This was causing sdio bus failure on resume.
>> >
>> > Remove this manual power on/off sequence as it is in-fact not needed.
>> >
>> > Signed-off-by: Eyal Reizer <eyalr@ti.com>
>> > Acked-by: Tony Lindgren <tony@atomide.com>
>>
>> No changelog.
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp
>> atches#changelog_missing
>>
>> No need to resubmit because of this, I guess you just fixed the title
>> and added Tony's Acked-by?
>
> Yes, this is correct. No change in the actual patch hence there was no change
> Log.
_Always_ include a change log, even if you didn't actually change
anything. Otherwise the maintainer has no clue what has changed and why
a new version was submitted.
--
Kalle Valo
next prev parent reply other threads:[~2018-04-26 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 5:47 [PATCH v2] wlcore: sdio: allow pm to handle sdio power Eyal Reizer
2018-04-26 8:16 ` Kalle Valo
2018-04-26 8:37 ` [EXTERNAL] " Reizer, Eyal
2018-04-26 9:26 ` Kalle Valo [this message]
2018-04-26 10:14 ` Reizer, Eyal
2018-04-30 10:31 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgda71zl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=eyalr@ti.com \
--cc=eyalreizer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).