Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

[Kalle Valo <kvalo@codeaurora.org>]

Arend van Spriel <arend.vanspriel@broadcom.com> writes:

> On 8/2/2017 11:32 AM, Kalle Valo wrote:
>> Wright Feng <wright.feng@cypress.com> writes:
>>
>>> The num_different_channels in wiphy info is not correct when firmware
>>> supports mchan. When mchan is on, num_different_channels is always
>>> overridden to 1 in brcmf_setup_ifmodes. Correct the logic by moving
>>> num_different_channels setting forward.
>>>
>>> Signed-off-by: Wright Feng <wright.feng@cypress.com>
>>
>> Does this fix a user visible bug? If yes, it would be nice to document
>> that.
>
> Hi Kalle,
>
> Depends on the users expectation ;-) When the device/firmware supports
> multi-channel (better not use mchan abbreviation) it can have P2P
> connection and regular connection with AP simultaneous. So the current
> state is that this is not possible regardless whether mchan is
> supported. So the device is not used to fullest extent.

Thanks, I understand now and I think your description should be also in
the commit log so that others will also :)

My usual mantra: the commit log should ALWAYS answer the question "_why_
the change is made?" and describe the reason what motivated to implement
the patch. This is the most important part. It helps maintainers,
backports, distros etc to make decisions if the patch is important for
them or not.

-- 
Kalle Valo