From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37570 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871AbdGUIAt (ORCPT ); Fri, 21 Jul 2017 04:00:49 -0400 From: Kalle Valo To: Pavel Machek Cc: Cong Wang , davem@davemloft.net, Andrew Morton , netdev@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [Patch net] wl1251: add a missing spin_lock_init() References: <1499378437-4971-1-git-send-email-xiyou.wangcong@gmail.com> <20170721075407.GA21902@amd> Date: Fri, 21 Jul 2017 11:00:44 +0300 In-Reply-To: <20170721075407.GA21902@amd> (Pavel Machek's message of "Fri, 21 Jul 2017 09:54:07 +0200") Message-ID: <87lgni2p8z.fsf@kamboji.qca.qualcomm.com> (sfid-20170721_100054_040575_33528CF3) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Pavel Machek writes: > On Thu 2017-07-06 15:00:37, Cong Wang wrote: >> This fixes the following kernel warning: >> >> [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 >> [ 5668.771850] lock: 0xce63ef20, .magic: 00000000, .owner: /-1, >> .owner_cpu: 0 > ... >> by adding the missing spin_lock_init(). >> >> Reported-by: Pavel Machek >> Cc: Kalle Valo >> Signed-off-by: Cong Wang > > > Ping? This is pretty trivial bugfix for an ugly problem. It would be > nice to take it in. I was on vacation, catching up now but I have 300+ patches in patchwork so it will take a while before I have gone through all of them. -- Kalle Valo