From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org
Subject: Re: [PATCH] ath9k: clean up and fix ath_tx_count_airtime
Date: Sun, 12 Feb 2017 16:22:02 +0100 [thread overview]
Message-ID: <87lgtb5t9h.fsf@alrua-karlstad> (raw)
In-Reply-To: <20170212132931.43510-1-nbd@nbd.name> (Felix Fietkau's message of "Sun, 12 Feb 2017 14:29:31 +0100")
Felix Fietkau <nbd@nbd.name> writes:
> ath_tx_count_airtime is doing a lot of unnecessary work:
>
> - Redundant station lookup
> - Redundant rcu_read_lock/unlock
> - Useless memcpy of bf->rates
> - Useless NULL check of bf->bf_mpdu
> - Redundant lookup of the skb tid
>
> Additionally, it tries to look up the mac80211 queue index from the txq,
> which fails if the frame was delivered via the power save queue.
>
> This patch fixes all of these issues by passing down the right set of
> pointers instead of doing extra work
>
> Cc: stable@vger.kernel.org
> Fixes: 63fefa050477 ("ath9k: Introduce airtime fairness scheduling betwee=
n stations")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Not sure if there's anything for stable to do with this; don't think the
airtime fairness code has gone into a release yet? Otherwise:
Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
-Toke
next prev parent reply other threads:[~2017-02-12 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 13:29 [PATCH] ath9k: clean up and fix ath_tx_count_airtime Felix Fietkau
2017-02-12 15:22 ` Toke Høiland-Jørgensen [this message]
2017-02-12 15:54 ` Felix Fietkau
2017-02-12 16:28 ` Kalle Valo
2017-02-12 16:32 ` Felix Fietkau
2017-02-12 16:36 ` Toke Høiland-Jørgensen
2017-02-12 16:40 ` Felix Fietkau
2017-02-12 18:13 ` Toke Høiland-Jørgensen
2017-02-13 15:28 ` Kalle Valo
2017-02-14 17:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgtb5t9h.fsf@alrua-karlstad \
--to=toke@toke.dk \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox