From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:61245 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbbKZQ6w (ORCPT ); Thu, 26 Nov 2015 11:58:52 -0500 From: Kalle Valo To: Mark Brown CC: , , , , , Subject: Re: next-20151126 build: 3 failures 15 warnings (next-20151126) References: <20151126121551.GE1929@sirena.org.uk> <87y4dllysz.fsf@kamboji.qca.qualcomm.com> <20151126132228.GG1929@sirena.org.uk> Date: Thu, 26 Nov 2015 18:58:32 +0200 In-Reply-To: <20151126132228.GG1929@sirena.org.uk> (Mark Brown's message of "Thu, 26 Nov 2015 13:22:28 +0000") Message-ID: <87lh9kn1dz.fsf@kamboji.qca.qualcomm.com> (sfid-20151126_175901_103560_9C69FF9C) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Mark Brown writes: > On Thu, Nov 26, 2015 at 02:39:40PM +0200, Kalle Valo wrote: >> Mark Brown writes: > >> > It looks like this was somehow triggered as part of the reorganisation >> > of the WiFi directory structure. > >> This is surprising and also worrying, any ideas why? It would be good to >> understand the root cause in case there's a bug in wireless drivers >> directory reorganisation. > > No, I didn't make much effort to check though since the use of ifdef was > clearly a bug waiting to happen anyway, I was more surprised it worked > at all than anything. Michal Marek explains[1] that this is due to commit cf4f21938e13 ("kbuild: Allow to specify composite modules with modname-m") and has nothing to do with the wireless drivers reorganisation. I'll drop this patch as Michal will apply his fix to the kbuild tree. [1] https://patchwork.kernel.org/patch/7707801/ -- Kalle Valo