From: Kalle Valo <kvalo@kernel.org>
To: "Nicolas Escande" <nico.escande@gmail.com>
Cc: "Santhosh Ramesh" <quic_santrame@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Sathishkumar Muruganandam" <quic_murugana@quicinc.com>
Subject: Re: [PATCH] wifi: ath12k: fix tx power, max reg power update to firmware
Date: Mon, 09 Sep 2024 12:07:58 +0300 [thread overview]
Message-ID: <87mskhgpox.fsf@kernel.org> (raw)
In-Reply-To: <D41LUTO0MIC3.12475D2J3VNX3@gmail.com> (Nicolas Escande's message of "Mon, 09 Sep 2024 10:20:02 +0200")
"Nicolas Escande" <nico.escande@gmail.com> writes:
> On Mon Sep 9, 2024 at 9:30 AM CEST, Santhosh Ramesh wrote:
>
> [...]
>
>> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
>> index 137394c36460..6d7a005d83b4 100644
>> --- a/drivers/net/wireless/ath/ath12k/mac.c
>> +++ b/drivers/net/wireless/ath/ath12k/mac.c
>> @@ -7217,9 +7217,9 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif,
>> chandef->chan->band,
>> arvif->vif->type);
>> arg.min_power = 0;
>> - arg.max_power = chandef->chan->max_power * 2;
>> - arg.max_reg_power = chandef->chan->max_reg_power * 2;
>> - arg.max_antenna_gain = chandef->chan->max_antenna_gain * 2;
>> + arg.max_power = chandef->chan->max_power;
>> + arg.max_reg_power = chandef->chan->max_reg_power;
>> + arg.max_antenna_gain = chandef->chan->max_antenna_gain;
>>
>
> For what it's worth, I already got a similar patch from QCA a few month ago, and
> it fixed some tx power problems when scanning so I know there is truth in this.
What hardware and what firmware did you use? The firmware branches can
behave differently so whenever testing something it's good to include
that info.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-09 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 7:30 [PATCH] wifi: ath12k: fix tx power, max reg power update to firmware Santhosh Ramesh
2024-09-09 8:20 ` Nicolas Escande
2024-09-09 9:07 ` Kalle Valo [this message]
2024-09-09 10:23 ` Nicolas Escande
2024-09-09 11:15 ` Kalle Valo
2024-09-09 12:55 ` Nicolas Escande
[not found] ` <93d580b4-cf7a-471f-8f3a-673d456f726f@quicinc.com>
2024-09-20 4:43 ` Santhosh Ramesh
2024-09-20 7:15 ` Nicolas Escande
2024-12-13 8:42 ` Nicolas Escande
2024-12-12 14:37 ` Kalle Valo
2025-01-07 1:27 ` Aditya Kumar Singh
2025-01-08 0:32 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mskhgpox.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico.escande@gmail.com \
--cc=quic_murugana@quicinc.com \
--cc=quic_santrame@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).