From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9DA3A1AC; Thu, 25 Apr 2024 06:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714024831; cv=none; b=asBTR6LoRmrnN0JKeuydz1CnzJkEWhKzR9gPdJO/Jzgb1YjxHqzjl5NnRb7htRJnn0TGQ6TRmgFFaBTF8n2wao6NbBusWaqvaKF7rI/2xAuJPnY7hIcm3hxaHBs5OpDoisYXw5FGMpVDnBZqXSEsV532xuqZoFNKge+fT9r7hrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714024831; c=relaxed/simple; bh=WfpvmkAUhIxwM5Xp8odvYw4dS6f/rUuQUBeFZ5BtH88=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=aHqJZw9dQOS0SXmGdhSTLiX2fGu/E0gy1+VamN5DlsmX4PcaIZQrqGj2+bkLLNL2pu8U1TnnoLy8kg05Adrhs9X4xTlLd/uLAu/vNmLG/bOqDoHnXeUf1csRH+d7q9gSph3QGZHpQvKHP88eWynFEABh28BkE2xm6ydVKxUwgoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HN/4PB95; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HN/4PB95" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE6BEC113CC; Thu, 25 Apr 2024 06:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714024831; bh=WfpvmkAUhIxwM5Xp8odvYw4dS6f/rUuQUBeFZ5BtH88=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HN/4PB95D1mAtqLQig4LiFXZ9mYrgJT5E1YHppqiC+GjUUsuTzpr2bzUeiGIrupbL 006NXSuFDMqxHpCM7JTbgIf0GUlLMsCkY+MiJIPBlnNwgRVhoOFGmaPq3So/A5mCxF JobIiR4t6tckVGH9voGGDL+vf2BPDsVmg8/5ck0jLzNA/buhKZOKuavHoFZXKHTk45 7US6NX7A0niFQTXOLHBKqHFs69LnOmwwF3bnRBTj7f81tInYkC9+qSvNZAVXDYmLWK Yz4wuSvXbQ8avpsuGJ9Ne/gkSgUlAhG7fGswp+ORGL5NZGryj9FmbITVdjXrkXKDp8 qY7luRJkkTbxg== From: Kalle Valo To: Ping-Ke Shih Cc: Breno Leitao , "leit@meta.com" , "open list:REALTEK WIRELESS DRIVER (rtw89)" , open list Subject: Re: [PATCH wireless] wifi: rtw89: Un-embed dummy device References: <20240424182351.3936556-1-leitao@debian.org> <87ttjqgf2r.fsf@kernel.org> Date: Thu, 25 Apr 2024 09:00:27 +0300 In-Reply-To: <87ttjqgf2r.fsf@kernel.org> (Kalle Valo's message of "Thu, 25 Apr 2024 08:57:00 +0300") Message-ID: <87mspigex0.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Kalle Valo writes: > Ping-Ke Shih writes: > >> Breno Leitao wrote: >>> Embedding net_device into structures prohibits the usage of flexible >>> arrays in the net_device structure. For more details, see the discussion >>> at [1]. >>> >>> Un-embed the net_device from the private struct by converting it >>> into a pointer. Then use the leverage the new alloc_netdev_dummy() >>> helper to allocate and initialize dummy devices. >>> >>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ >>> >>> Signed-off-by: Breno Leitao >> >> I think this patch should go via net-next tree, because wireless-next tree >> doesn't have patch of dummy devices yet. >> >> Acked-by: Ping-Ke Shih > > FWIW I sent the wireless-next pull request yesterday and once it pulled > we will fast forward wireless-next to latest net-next. Oh, I just realised that this is not CCed to netdev so their patchwork won't even see the patch. Ping, I recommend that you wait for the dependency commits to trickle down to your tree and then apply the patch. That's the simplest approach and no need to resend anything. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches