From: Kalle Valo <kvalo@kernel.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b
Date: Sat, 21 May 2022 08:52:58 +0300 [thread overview]
Message-ID: <87mtfbwhxh.fsf@kernel.org> (raw)
In-Reply-To: <20220520184528.4078-2-Larry.Finger@lwfinger.net> (Larry Finger's message of "Fri, 20 May 2022 13:45:25 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> Sparse lists the following for rtw88:
>
> CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c
> drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static?
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
It's good to try to make title's unique, so maybe something like this:
rtw88: make rtw8822b_hw_spec static
> ---
> drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> index dccd722b8e62..60c4e75df035 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> @@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = {
> [EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0},
> };
>
> -struct rtw_chip_info rtw8822b_hw_spec = {
> +static struct rtw_chip_info rtw8822b_hw_spec = {
This should be static const to make sure it's not modified.
Similar comments for other patches in this patchset.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-21 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 18:45 [PATCH 0/4] rtw88: Fix some Sparse warnings Larry Finger
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
2022-05-21 5:52 ` Kalle Valo [this message]
2022-05-23 0:45 ` Ping-Ke Shih
2022-05-20 18:45 ` [PATCH 2/4] rtw88: Fix Sparse warning for rtw8822c Larry Finger
2022-05-20 18:45 ` [PATCH 3/4] rtw88: Fix Sparse warning for rtw8723d Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtfbwhxh.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).