From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB6CC5519F for ; Wed, 25 Nov 2020 14:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEE7520715 for ; Wed, 25 Nov 2020 14:03:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="tj4ZrV8G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729016AbgKYOD4 (ORCPT ); Wed, 25 Nov 2020 09:03:56 -0500 Received: from z5.mailgun.us ([104.130.96.5]:51139 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727980AbgKYODz (ORCPT ); Wed, 25 Nov 2020 09:03:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606313035; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=AdYaiLbWnIbpHPcrytqIwW8GXgqzM6O7eGeSovv+j/0=; b=tj4ZrV8GNbMueyuERdD3mfnOYj6W7G9rlr1PVS4s2aujBsY4+kTfLaY/B6H9HVa+TA8rADp5 SNDtsG+ajS0Nxrj7QIj5eZLG1fcBBCj7a4TIIdaq7AjCDIUYEDZrEVE9M3RzPPBJZlDkSlzZ 6vrimHt8jPacYO8EzIOicBa8Kq8= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5fbe643a77b63cdb3440bb41 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 25 Nov 2020 14:03:38 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B85B2C433C6; Wed, 25 Nov 2020 14:03:37 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1123DC43460; Wed, 25 Nov 2020 14:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1123DC43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Anilkumar Kolli Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath11k: fix rmmod failure if qmi sequence fails References: <1605076699-21924-1-git-send-email-akolli@codeaurora.org> Date: Wed, 25 Nov 2020 16:03:33 +0200 In-Reply-To: <1605076699-21924-1-git-send-email-akolli@codeaurora.org> (Anilkumar Kolli's message of "Wed, 11 Nov 2020 12:08:19 +0530") Message-ID: <87mtz5pm8a.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Anilkumar Kolli writes: > QMI sequence fails if caldata file is not available. > It is observed that 'rmmod ath11k' fails if qmi message fails. > With this patch rmmod/insmod is working. > > Logs: > Direct firmware load for IPQ8074/caldata.bin failed with error -2 > Falling back to user helper > qmi failed to load CAL: IPQ8074/caldata.bin > qmi failed to load board data file:-11 > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Anilkumar Kolli With this patch reloading ath11k (which has worked fine before) crashes the kernel on QCA6390 hw2.0: Nov 25 16:00:52 nuc1 [ 393.188277] BUG: unable to handle page fault for address: ffffffffc05b8e38 Nov 25 16:00:52 nuc1 [ 393.188300] #PF: supervisor read access in kernel mode Nov 25 16:00:52 nuc1 [ 393.188312] #PF: error_code(0x0000) - not-present page -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches