From: Kalle Valo <kvalo@codeaurora.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: ath10k@lists.infradead.org, vnaralas@codeaurora.org,
linux-wireless@vger.kernel.org,
Sven Eckelmann <seckelmann@datto.com>
Subject: Re: [RFC PATCH 1/2] ath10k: report survey info as accumulated values
Date: Fri, 11 Oct 2019 11:41:56 +0300 [thread overview]
Message-ID: <87mue7znaj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190918124259.17804-2-sven@narfation.org> (Sven Eckelmann's message of "Wed, 18 Sep 2019 14:42:58 +0200")
Sven Eckelmann <sven@narfation.org> writes:
> From: Sven Eckelmann <seckelmann@datto.com>
>
> The survey report is expected to contain a counter which is increasing all
> the time. But ath10k reports some kind of delta. This can either be the
> difference to the last get_survey or the difference to some even older
> get_survey because the values are sometimes cached and sometimes
> overwritten.
>
> To make the returned values useful, they must be accumulated manually by
> ath10k before send out to the upper layers. Special care must be taken when
> accepting values from older firmware versions (which use
> ATH10K_HW_CC_WRAP_SHIFTED_ALL) because they will not clear the cycle_busy
> and cycle_total counter and will only use 31 bit of the 64 but counter.
Please clarify a bit more which older firmware versions you are talking
about, we have so many of them :) I assume you are talking about _all_
QCA988X and QCA9887 firmware versions, but it would be nice to clarify
that in the commit log.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-11 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 12:42 [RFC PATCH 0/2] ath10k: provide survey info as accumulated data Sven Eckelmann
2019-09-18 12:42 ` [RFC PATCH 1/2] ath10k: report survey info as accumulated values Sven Eckelmann
2019-10-11 8:41 ` Kalle Valo [this message]
2019-09-18 12:42 ` [RFC PATCH 2/2] ath10k: regularly fetch survey counters Sven Eckelmann
2019-10-11 8:40 ` Kalle Valo
2019-10-11 8:44 ` [RFC PATCH 0/2] ath10k: provide survey info as accumulated data Kalle Valo
2019-10-13 22:15 ` Sebastian Gottschall
2019-10-14 7:07 ` Sven Eckelmann
2019-10-14 8:57 ` Kalle Valo
2019-10-14 9:32 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mue7znaj.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=seckelmann@datto.com \
--cc=sven@narfation.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).