linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>,
	<gregkh@linuxfoundation.org>, <sgruszka@redhat.com>,
	<pkshih@realtek.com>, <tehuang@realtek.com>,
	<briannorris@chromium.org>, <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v8 14/14] staging: rtlwifi: remove staging rtlwifi driver
Date: Tue, 19 Mar 2019 23:01:16 +0200	[thread overview]
Message-ID: <87mulqtw83.fsf@codeaurora.org> (raw)
In-Reply-To: <1552450443-351-15-git-send-email-yhchuang@realtek.com> (yhchuang@realtek.com's message of "Wed, 13 Mar 2019 12:14:03 +0800")

<yhchuang@realtek.com> writes:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> The rtlwifi driver is conflicting with Realtek's new 802.11ac chip
> series driver rtw88, remove it to avoid racing with the same ID.
>
> The rtw88 driver can be found at drivers/net/wireless/realtek/rtw88
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
>  drivers/staging/Kconfig                            |     2 -
>  drivers/staging/Makefile                           |     1 -
>  drivers/staging/rtlwifi/Kconfig                    |    12 -
>  drivers/staging/rtlwifi/Makefile                   |    70 -
>  drivers/staging/rtlwifi/TODO                       |    11 -
>  drivers/staging/rtlwifi/base.c                     |  2815 ----
>  drivers/staging/rtlwifi/base.h                     |   175 -

[...]

>  drivers/staging/rtlwifi/stats.c                    |   249 -
>  drivers/staging/rtlwifi/stats.h                    |    31 -
>  drivers/staging/rtlwifi/wifi.h                     |  3362 -----
>  183 files changed, 123718 deletions(-)
>  delete mode 100644 drivers/staging/rtlwifi/Kconfig
>  delete mode 100644 drivers/staging/rtlwifi/Makefile
>  delete mode 100644 drivers/staging/rtlwifi/TODO
>  delete mode 100644 drivers/staging/rtlwifi/base.c
>  delete mode 100644 drivers/staging/rtlwifi/base.h

[...]

> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -40,8 +40,6 @@ source "drivers/staging/rtl8712/Kconfig"
>  
>  source "drivers/staging/rtl8188eu/Kconfig"
>  
> -source "drivers/staging/rtlwifi/Kconfig"
> -
>  source "drivers/staging/rts5208/Kconfig"
>  
>  source "drivers/staging/octeon/Kconfig"
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index 5868631..49e436f 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -10,7 +10,6 @@ obj-$(CONFIG_RTL8192E)		+= rtl8192e/
>  obj-$(CONFIG_RTL8723BS)		+= rtl8723bs/
>  obj-$(CONFIG_R8712U)		+= rtl8712/
>  obj-$(CONFIG_R8188EU)		+= rtl8188eu/
> -obj-$(CONFIG_R8822BE)		+= rtlwifi/
>  obj-$(CONFIG_RTS5208)		+= rts5208/
>  obj-$(CONFIG_NETLOGIC_XLR_NET)	+= netlogic/
>  obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
> diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
> deleted file mode 100644
> index 7b4276f5..0000000
> --- a/drivers/staging/rtlwifi/Kconfig
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -config R8822BE
> -	tristate "Realtek RTL8822BE Wireless Network Adapter"
> -	depends on PCI && MAC80211 && m
> -	select FW_LOADER
> -	---help---
> -	This is the staging driver for Realtek RTL8822BE 802.11ac PCIe
> -	wireless network adapters.
> -
> -config RTLWIFI_DEBUG_ST
> -	bool
> -	depends on R8822BE
> -	default y

This patch is huge and does not make it to the list because of the size.
Is there a way to optimise the size, any ideas? At least 'git
format-patch -M' or '-C' didn't help, just tried that.

-- 
Kalle Valo

  parent reply	other threads:[~2019-03-19 21:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13  4:13 [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2019-03-13  4:13 ` [PATCH v8 01/14] rtw88: main files yhchuang
2019-03-15  8:28   ` Johannes Berg
2019-03-13  4:13 ` [PATCH v8 02/14] rtw88: core files yhchuang
2019-03-13  4:13 ` [PATCH v8 03/14] rtw88: hci files yhchuang
2019-03-25 14:34   ` Brian Norris
2019-03-27  5:07     ` Tony Chuang
2019-03-13  4:13 ` [PATCH v8 04/14] rtw88: trx files yhchuang
2019-03-13  4:13 ` [PATCH v8 05/14] rtw88: mac files yhchuang
2019-03-13  4:13 ` [PATCH v8 06/14] rtw88: fw and efuse files yhchuang
2019-03-13  4:13 ` [PATCH v8 07/14] rtw88: phy files yhchuang
2019-03-13  4:13 ` [PATCH v8 08/14] rtw88: debug files yhchuang
2019-03-13  4:13 ` [PATCH v8 09/14] rtw88: chip files yhchuang
2019-03-13  4:13 ` [PATCH v8 10/14] rtw88: 8822B init table yhchuang
2019-03-13  4:14 ` [PATCH v8 11/14] rtw88: 8822C " yhchuang
2019-03-13  4:14 ` [PATCH v8 12/14] rtw88: Kconfig & Makefile yhchuang
2019-03-13  4:14 ` [PATCH v8 13/14] rtw88: add MAINTAINERS entry yhchuang
2019-03-13  6:48 ` [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Kalle Valo
2019-03-13  7:06   ` Tony Chuang
2019-03-13  7:10     ` Kalle Valo
     [not found] ` <1552450443-351-15-git-send-email-yhchuang@realtek.com>
2019-03-19 21:01   ` Kalle Valo [this message]
2019-03-25 14:36 ` Brian Norris
2019-03-26  7:54   ` Stanislaw Gruszka
2019-03-26 15:43     ` Brian Norris
2019-03-27  4:59       ` Tony Chuang
2019-03-27 10:26         ` Stanislaw Gruszka
2019-04-08  2:14           ` Tony Chuang
2019-04-08 11:33             ` Kalle Valo
2019-04-09 10:12               ` Tony Chuang
2019-04-18 13:55                 ` Kalle Valo
2019-04-19  8:23                   ` Tony Chuang
2019-04-19 21:01                     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mulqtw83.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=briannorris@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=sgruszka@redhat.com \
    --cc=tehuang@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).