* Re: [PATCH] net: arp, ipv6: handle special case of tap device
[not found] ` <2058134821.17788321.1538573112620.JavaMail.zimbra@redhat.com>
@ 2018-10-04 9:53 ` Kalle Valo
0 siblings, 0 replies; only message in thread
From: Kalle Valo @ 2018-10-04 9:53 UTC (permalink / raw)
To: Vladis Dronov
Cc: David Miller, kuznet, yoshfuji, netdev, syzkaller, linux-kernel,
linux-wireless
Vladis Dronov <vdronov@redhat.com> writes:
>> From: "David Miller" <davem@davemloft.net>
>> Sent: Wednesday, October 3, 2018 7:25:40 AM
>>
>> > Probably, this functionality is already used by some userspace, so I
>> > believe, I cannot just remove TUNSETLINK ioctl.
>>
>> Who uses it, how do they use it, and what do they sanely expect about
>> the link layer header properties of a tap device which has had ->type
>> changed?
>
> Honestly, I have no idea. I was working on a syzkaller bug report and
> found that the reason for that bug was TUNSETLINK ioctl.
>
> This ioctl was introduced 13 years ago with ff4cc3ac93e1d and it says:
>
>> For use with
>> wireless and other networking types it should be possible to set the
>> ARP type via an ioctl.
>
> , that's all. Let me try to prepare a patch that sets dev->addr_len and
> dev->broadcast according to dev->type. I would probably need an advise
> what other fields must be adjusted too.
>
> Otherwise, we can just to remove the TUNSETLINK ioctl.
Let's add linux-wireless in case someone there knows about the ioctl.
--
Kalle Valo
^ permalink raw reply [flat|nested] only message in thread