From: Kalle Valo <kvalo@codeaurora.org>
To: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Variable-length arrays considered bad
Date: Fri, 09 Mar 2018 12:38:01 +0200 [thread overview]
Message-ID: <87muzha60m.fsf@codeaurora.org> (raw)
In-Reply-To: <CAEhWJF=s=gHJ-yKn+VW2Hs6Nj9KbfF59-1Tk=fkzQk6wFFddNw@mail.gmail.com> (Amitkumar Karwar's message of "Fri, 9 Mar 2018 12:58:54 +0530")
Amitkumar Karwar <amitkarwar@gmail.com> writes:
> On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Hi,
>>
>> in an lkml discussion[1] it was mentioned that variable-length arrays
>> should not be used. Few warnings were found[2] from wireless:
>>
>> drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids
>> variable length array 'max_bin' [-Wvla]
>> drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90
>> forbids variable length array 'temp_buf' [-Wvla]
>>
>> Patches welcome.
>>
>> [1]
>> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>>
>> [2] http://paste.ubuntu.com/p/srQxwPQS9s/
>>
>
> I will submit a cleanup patch for RSI warning
Thanks, but Tobin was faster:
https://lkml.kernel.org/r/1520577493-24603-1-git-send-email-me@tobin.cc
He just forgot to CC linux-wireless.
--
Kalle Valo
prev parent reply other threads:[~2018-03-09 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 8:40 Variable-length arrays considered bad Kalle Valo
2018-03-09 7:28 ` Amitkumar Karwar
2018-03-09 10:38 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muzha60m.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).